Set default value of assignedDeleteTimeout #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulji
requested review from
aLekSer,
HazWard,
calebatwd,
syntxerror,
sawagh,
andrewgrundy and
scosgrave
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it: It has been found that if
assignedDeleteTimeoutis not set in values.yaml file then Open-Match fails silently as found in the logs of open-match-backend and pods continue to run and doesn't crash.This PR implements the code to set the default value of
assignedDeleteTimeoutwhich is10 minutesfor now.Which issue(s) this PR fixes:
Closes #1247
Special notes for your reviewer: