Add build support for arm64-linux

[kaboing]

Adds support for arm64-linux.

Uses buildx to build multi-platform image.

Spawned by: #611

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

What this PR does / Why we need it:
Adds support for arm64/linux. Builds multi-platform using buildx.

Which issue(s) this PR fixes:

Closes #611

Special notes for your reviewer:

[kaboing]

/gcbrun

[markmandel]

/gcbrun

[markmandel]

Was make build working for you locally?

[kaboing]

Yeah, it works on my machine ™️ . I build on an apple m2 pro with docker-desktop.

I noticed that the error messages complains about building ring, but I don't know if that is relevant.

Step #5 - "build": Caused by:
Step #5 - "build":   process didn't exit successfully: `/workspace/target/build-image/lto/build/ring-f1972dd2a537ad30/build-script-build` (exit status: 1)
Step #5 - "build":   --- stdout
Step #5 - "build":   cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
Step #5 - "build":   cargo:rustc-env=RING_CORE_PREFIX=ring_core_0_17_8_
Step #5 - "build":   OPT_LEVEL = Some(3)
Step #5 - "build":   OUT_DIR = Some(/workspace/target/build-image/aarch64-unknown-linux-gnu/lto/build/ring-02bad55d8023c288/out)
Step #5 - "build":   TARGET = Some(aarch64-unknown-linux-gnu)
Step #5 - "build":   HOST = Some(x86_64-unknown-linux-gnu)
Step #5 - "build":   cargo:rerun-if-env-changed=CC_aarch64-unknown-linux-gnu
Step #5 - "build":   CC_aarch64-unknown-linux-gnu = None
Step #5 - "build":   cargo:rerun-if-env-changed=CC_aarch64_unknown_linux_gnu
Step #5 - "build":   CC_aarch64_unknown_linux_gnu = None
Step #5 - "build":   cargo:rerun-if-env-changed=TARGET_CC
Step #5 - "build":   TARGET_CC = None
Step #5 - "build":   cargo:rerun-if-env-changed=CC
Step #5 - "build":   CC = None
Step #5 - "build":   cargo:rerun-if-env-changed=CROSS_COMPILE
Step #5 - "build":   CROSS_COMPILE = None
Step #5 - "build":   RUSTC_LINKER = Some(/usr/bin/aarch64-linux-gnu-gcc)
Step #5 - "build":   cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
Step #5 - "build":   cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `/usr/bin/aarch64-linux-gnu-gcc` installed?
Step #5 - "build":   RUSTC_WRAPPER = None
Step #5 - "build":   cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
Step #5 - "build":   CRATE_CC_NO_DEFAULTS = None
Step #5 - "build":   DEBUG = Some(false)
Step #5 - "build":   CARGO_CFG_TARGET_FEATURE = Some(aes,neon)
Step #5 - "build":   cargo:rerun-if-env-changed=CFLAGS_aarch64-unknown-linux-gnu
Step #5 - "build":   CFLAGS_aarch64-unknown-linux-gnu = None
Step #5 - "build":   cargo:rerun-if-env-changed=CFLAGS_aarch64_unknown_linux_gnu
Step #5 - "build":   CFLAGS_aarch64_unknown_linux_gnu = None
Step #5 - "build":   cargo:rerun-if-env-changed=TARGET_CFLAGS
Step #5 - "build":   TARGET_CFLAGS = None
Step #5 - "build":   cargo:rerun-if-env-changed=CFLAGS
Step #5 - "build":   CFLAGS = None
Step #5 - "build":   cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `/usr/bin/aarch64-linux-gnu-gcc` installed?
Step #5 - "build": 
Step #5 - "build":   --- stderr
Step #5 - "build": 
Step #5 - "build": 
Step #5 - "build":   error occurred: Failed to find tool. Is `aarch64-linux-gnu-gcc` installed?

[kaboing]

/gcbrun

[kaboing]

Added setting CC explicitly, as suggested by briansmith/ring#2127.
Seems I need someone to do a /gcbrun for the PR

[kaboing]

I'm new to the Rust eco-system so I'm mainly searching the internet to find people who's had similar issues.

[XAMPPRocky]

/gcbrun

[markmandel]

Yeah, it works on my machine ™️ . I build on an apple m2 pro with docker-desktop.

Ah fun, so you would be building on ARM, and Cloud Build is building on Intel.

My suggestion would be to add the package g++-aarch64-linux-gnu to

quilkin/build/build-image/Dockerfile

Lines 28 to 31 in 00345be

	RUN set -eux && \
	apt-get update && \
	apt-get install -y lsb-release jq curl wget zip git build-essential software-properties-common protobuf-compiler \
	libssl-dev pkg-config nodejs npm bash-completion g++-x86-64-linux-gnu g++-mingw-w64-x86-64 && \

Which should give the system what it needs, when it says:

Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is aarch64-linux-gnu-gcc installed?

[kaboing]

Gotcha. Let's test this version then!

[markmandel]

/gcbrun

[XAMPPRocky]

ERROR: multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")

[kaboing]

Updated PR to use docker-container as build driver. However, according to docs,

Unlike docker driver, built images will not automatically appear in docker images and build --load needs to be used to achieve that.

Docs for build --load

Shorthand for --output=type=docker. Will automatically load the single-platform build result to docker images.

=> does not seem to work for multi-arch images. So we perhaps need to restructure a bit to push directly, or configure some other reasonable output. Any thoughts on this?

[markmandel]

does not seem to work for multi-arch images

In my experience the multi arch image is stored temporarily in the build cache, so a subsequent build with --push will be almost immediate, because it won't rebuild.

[markmandel]

/gcbrun

[markmandel]

Well it built! But the image could not be found after the fact.

[kaboing]

Well, it's progress at least! And I see in the logs that it build for both architectures, so that's nice.
When trying --load locally (latest commit), the entire thing hanged on sending the resulting tarball, but let's at least try it in the gcb environment and see what happens.

[XAMPPRocky]

/gcbrun

[quilkin-bot]

Build Failed 😭

Build Id: b7934c3b-ffa0-49d8-82c1-2019af4fbe27

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Filter with the Git Commit 78cea0a within us-docker.pkg.dev/quilkin/ci//quilkin to see if a development image is available from this build, and can be used for debugging purposes.

Development images are retained for at least 30 days.