refactor: Make DownstreamPacket sans-io #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
koslib and
Jake-Shadle
as code owners
Jake-Shadle
approved these changes
Jan 8, 2025
XAMPPRocky
force-pushed
the
ep/generic-downstream
branch
from
c54e01a to
a29fc0d
Compare
This moves the DownstreamPacket struct to be completely sans-IO, meaning it is now generic over any input container and output container. This is just a basic shell right now to enable building and testing more stuff without IO, and to enable alternatives like XDP to integrate easily.
XAMPPRocky
force-pushed
the
ep/generic-downstream
branch
from
a29fc0d to
603ca6c
Compare
|
Build Succeeded 🥳 Build Id: 50772c11-4ed4-473f-9da4-35553f72ef1e The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the DownstreamPacket struct to be completely sans-IO, meaning it is now generic over any input container and output container. This is just a basic shell right now to enable building and testing more stuff without IO, and to enable alternatives like XDP to integrate easily.