This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Switch VerifyBamId to v1 Position objects. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proto2Coder is preferred because it is deterministic.
|
LGTM Thanks! |
deflaux
added a commit
that referenced
this pull request
Dec 10, 2015
Switch VerifyBamId to v1 Position objects.
jiridanek
pushed a commit
to jiridanek/dataflow-java
that referenced
this pull request
Jan 18, 2016
Switch VerifyBamId to v1 Position objects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VerifyBamId pipeline requires a deterministic coder due to the CoGroupByKey, hence the change to Proto2Coder which is deterministic and supports the v1 proto3 objects.
Note that this pipeline no longer requires GenericJsonCoder, but it does need Proto2Coder and SerializableCoder, so I just added more fallback logic to GenericJsonCoder so that we can just use it for all pipelines for the near term to keep the coder stuff simple.