This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Fixing a few bugs in ReadConverter #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a more comprehensive test for ReadConverter Added gat-tools-java as a dependency to access the Read->SAMRecord converter
| import htsjdk.samtools.CigarOperator; | ||
| import htsjdk.samtools.SAMException; | ||
| import htsjdk.samtools.SAMRecord; | ||
| import htsjdk.samtools.*; |
There was a problem hiding this comment.
We prefer to avoid wildcard imports (Google Java style)
|
Nice! Good test makes me happy. |
wbrockman
added a commit
that referenced
this pull request
Mar 31, 2015
Fixing a few bugs in ReadConverter and adding a new test for Sam -> Read -> Sam conversion.
|
@wbrockman You merged, did you want me to add that comment and fix the spacing? |
|
Yes please - sorry, crossing up my different review workflows. On Tue, Mar 31, 2015 at 10:26 AM, Louis Bergelson [email protected]
|
|
This line is my favorite :) |
jiridanek
pushed a commit
to jiridanek/dataflow-java
that referenced
this pull request
Jan 18, 2016
Fixing a few bugs in ReadConverter and adding a new test for Sam -> Read -> Sam conversion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a more comprehensive test for
ReadConverterAdded gat-tools-java as a dependency to access the
Read->SAMRecordconverter