Add an option to include call name in BQ table. #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanvp
approved these changes
Sep 30, 2020
| name=bigquery_util.ColumnKeyConstants.CALLS_NAME, | ||
| type=bigquery_util.TableFieldConstants.TYPE_STRING, | ||
| mode=bigquery_util.TableFieldConstants.MODE_NULLABLE, | ||
| description='Name of the call.')) |
There was a problem hiding this comment.
How about this:
'Name of the call (sample names in the VCF Header line).'
| parser.add_argument( | ||
| '--include_call_name', | ||
| type='bool', default=False, nargs='?', const=True, | ||
| help=('Add raw sample name as a separate column in sample record.')) |
There was a problem hiding this comment.
how about:
''Add raw sample name (from VCF Header line) as a subfield under the call column in addition to sample_id.''
| @@ -56,6 +57,7 @@ def __init__( | |||
| numeric (float/int/long) lists. For instance, [0, None, 1] will become | |||
| [0, `null_numeric_value_replacement`, 1]. If not set, the value will set | |||
| to bigquery_util._DEFAULT_NULL_NUMERIC_VALUE_REPLACEMENT. | |||
| include_call_name: If true, sample name will be included with sample ID. | |||
| @@ -89,6 +90,7 @@ def __init__( | |||
| numeric (float/int/long) lists. For instance, [0, None, 1] will become | |||
| [0, `null_numeric_value_replacement`, 1]. If not set, the value will set | |||
| to bigquery_util._DEFAULT_NULL_NUMERIC_VALUE_REPLACEMENT. | |||
| include_call_name: If true, sample name will be included with sample ID. | |||
tneymanov
commented
Oct 1, 2020
| name=bigquery_util.ColumnKeyConstants.CALLS_NAME, | ||
| type=bigquery_util.TableFieldConstants.TYPE_STRING, | ||
| mode=bigquery_util.TableFieldConstants.MODE_NULLABLE, | ||
| description='Name of the call.')) |
| @@ -56,6 +57,7 @@ def __init__( | |||
| numeric (float/int/long) lists. For instance, [0, None, 1] will become | |||
| [0, `null_numeric_value_replacement`, 1]. If not set, the value will set | |||
| to bigquery_util._DEFAULT_NULL_NUMERIC_VALUE_REPLACEMENT. | |||
| include_call_name: If true, sample name will be included with sample ID. | |||
| parser.add_argument( | ||
| '--include_call_name', | ||
| type='bool', default=False, nargs='?', const=True, | ||
| help=('Add raw sample name as a separate column in sample record.')) |
| @@ -89,6 +90,7 @@ def __init__( | |||
| numeric (float/int/long) lists. For instance, [0, None, 1] will become | |||
| [0, `null_numeric_value_replacement`, 1]. If not set, the value will set | |||
| to bigquery_util._DEFAULT_NULL_NUMERIC_VALUE_REPLACEMENT. | |||
| include_call_name: If true, sample name will be included with sample ID. | |||
tneymanov
force-pushed
the
duplicate_call_name
branch
from
d61d861 to
1d649d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.