Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object order in MapObjectManager.Collection is random #772

Closed
solcott opened this issue Aug 5, 2020 · 2 comments · Fixed by #972
Closed

Object order in MapObjectManager.Collection is random #772

solcott opened this issue Aug 5, 2020 · 2 comments · Fixed by #972
Assignees
@barbeau
Labels
released triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@solcott
Copy link

solcott commented Aug 5, 2020

Summary

The order in which objects are stored in MapObjectManager.Collection and subclasses is random. It is hard to compare the data stored here with other data sources for marker, polygon, etc.

Expected behavior

Storing data in a LinkedHashSet instead of a HashSet would keep the stored objects in the same order they were inserted

Observed Behavior

I have to create my own MapObjectManager, MarkerManager, etc to implement dragging Markers that also update a corresponding polygon.

Environment details

  1. Device make and model, or emulator details - Default Android 11 Emulator, Pixel 3, Samsung Tab 8
  2. Android version - Android 8-11 at least, haven't tried other versions
  3. Library version and other environment information - 2.0.3 and previous versions back to 1.5
@solcott solcott added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 5, 2020
jeffdgr8 added a commit to jeffdgr8/android-maps-utils that referenced this issue Sep 14, 2021
@jeffdgr8
Use LinkHashSet to maintain set order
f49aced 
Closes googlemaps#772
jeffdgr8 added a commit to jeffdgr8/android-maps-utils that referenced this issue Sep 14, 2021
@jeffdgr8
Use LinkHashSet to maintain set order
6400768 
Closes googlemaps#772
@jeffdgr8 jeffdgr8 mentioned this issue Sep 14, 2021
Merged
5 tasks
@jeffdgr8
Copy link
Contributor

Fixed in #972

barbeau pushed a commit that referenced this issue Sep 14, 2021
@jeffdgr8 @dependabot
fix: MapObjectManager.Collection object order (#972)
e6276a9 
* chore(deps): bump play-services-base from 17.2.1 to 17.6.0 (#846)

Bumps play-services-base from 17.2.1 to 17.6.0.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use LinkHashSet to maintain set order

Closes #772

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@solcott solcott mentioned this issue Oct 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barbeau barbeau

Labels
released triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: MapObjectManager.Collection object order jeffdgr8/android-maps-utils
4 participants
@solcott @barbeau @jeffdgr8 @googlemaps-bot