Build sdk for x86 and x86_64 ABIs too

[ShootingKing-AM]

• Since this Support for Android Studio x86 emulator? #13 is long solved and x86 are needed for running faster emulator (testing), why not build those ABIs too ?
• Google now enforces x86 images to be run latest android version avds
• Also otherwise for larger compatibility.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[arilow]

Thanks for your contribution @ShootingKing-AM !

As stated above, please sign the Contributor License Agreement (CLA) in order to contribute to Cardboard.

Once the CLA is signed, we can start the review process.

Thanks!

[ShootingKing-AM]

Thanks for your contribution @ShootingKing-AM !

As stated above, please sign the Contributor License Agreement (CLA) in order to contribute to Cardboard.

Once the CLA is signed, we can start the review process.

Thanks!

Thanks for your reply, i actually signed it already.

[ShootingKing-AM]

• Updated CI to bump JDK to fix compiler exception
• Now builds hellocarboard for x86_64 and x86 too (can act as compile time test)

[arilow]

Thanks @ShootingKing-AM for your pull request!

Internally, we have have divided it in 2:

• The fix for CI: This has been merged internally and will be part of release v1.21.0.
• Adding builds for x86 and x86_64 ABIs: We tested this and found that the size of the generated AAR file would increase significantly. That's why we have decided not to merge this change and instead add a new section to the quickstart explaining how to build for x86 and x86_64 ABIs if someone wants to test their app with the emulator.

Thanks for contributing to Cardboard!

[ShootingKing-AM]

• Adding builds for x86 and x86_64 ABIs: We tested this and found that the size of the generated AAR file would increase significantly. That's why we have decided not to merge this change and instead add a new section to the quickstart explaining how to build for x86 and x86_64 ABIs if someone wants to test their app with the emulator.

Nice idea ! Balancing both developer and user interests !

Thanks for your support.

[xinyunh0929]

This was fixed in v1.21.0