Remove unnecessary code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1\ The top level Dockerfile is for building the Rails app image which has no dependencies on JavaScript. As such all the code to pull down and install node, npm and yarn is unnecessary. 2\ yarn is already installed in the base `node` image so there is no reason to install it a second time
Containers are supposed to be as small as possible, so excluding build and log data is a good thing
Due to the immutability of Docker images every Dockerfile directive creates an intermediate layer which in turn increases the final images size. As such directives should be removed or combined where possible. * The 'COPY' directive will create a directory inside the container if it does not exist, so MKDIR /foo COPY . /foo can be reduced to COPY . /foo * There is no value to copying a specific file, and then copying the entire directory the file is in instead of copying the entire directory to begin with
|
I've added a few more commits to this PR. The main purpose of all of them is unchanged: remove unnecessary code to get this repo to work. I'm happy to explain any of my changes if they are confusing. |
As with the Ruby Dockerfile, the fewer Dockerfile directives the better. Additionally: - Combining N-many RUN directives into 1 with '&&' turns N-many layers into 1. A huge win - Mixing npm and yarn to install packages is confusing. Using a single package manager is preferred when possible. - For clarity the ENDPOINT or CMD directive that is run by `docker run` or `docker-compose up` should be at the end of the file. This is not a requirement, but it greatly improves readability.
benjdewan
force-pushed
the
remove-dead-code
branch
from
cd3bb32 to
53e399e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1\ The top level Dockerfile is for building the Rails app image which has no dependencies on JavaScript. As such all the code to pull down and install node, npm and yarn is unnecessary.
2\ yarn is already installed in the base
nodeimage so there is no reason to install it a second time