Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespaces array when reconnecting #547

Closed
cailloumajor opened this issue Jan 15, 2022 · 2 comments · Fixed by #552
Closed

Update namespaces array when reconnecting #547

cailloumajor opened this issue Jan 15, 2022 · 2 comments · Fixed by #552
Milestone
v0.3.1

Comments

@cailloumajor
Copy link

Hello, and thank you for your work on this project.
I am writing a proxy to allow subscribing to OPC-UA nodes realtime updates via Centrifugo: https://github.com/cailloumajor/opcua-centrifugo
I currently explore about how to use namespace URL, I read the code and also #512. This got me to a question: shouldn't the client cached namespaces array be refreshed in the reconnection process ?
I would be happy to submit a PR if needed.
@magiconair
Copy link
Member

Yes, I think that's a good idea. PR would be welcome.

magiconair added a commit that referenced this issue Jan 27, 2022
@magiconair
client: update namespaces on reconnect
4c6b35a 
Update the cached namespace array when reconnecting.

Fixes #547
@magiconair magiconair mentioned this issue Jan 27, 2022
Merged
@magiconair
Copy link
Member

It was easy to add. @cailloumajor could you test if this works for you?

@magiconair magiconair added this to the v0.3.1 milestone Jan 27, 2022
magiconair added a commit that referenced this issue Jan 27, 2022
@magiconair
client: update namespaces on reconnect
0264c0e 
Update the cached namespace array when reconnecting.

Fixes #547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

client: update namespaces on reconnect gopcua/opcua
2 participants
@magiconair @cailloumajor