Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change encryption URI for aes128Sha256RsaOaep to w3.org #585

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Change encryption URI for aes128Sha256RsaOaep to w3.org #585

merged 1 commit into from
Jun 15, 2022

Conversation

LarsStegman
Copy link
Contributor

Fix #584

@LarsStegman
Copy link
Contributor Author

@magiconair @dwhutchison Have you had time to review this?

@magiconair
Copy link
Member

I'll try to do that today. In the middle of a move.

@dwhutchison
Copy link
Collaborator

I was able to reproduce the error on the unpatched version with open62541 and this patch fixed it.
I also tested against the Ignition (Eclipse Milo) and Prosys servers and they accepted both versions.
If I get some more time I’ll try test against the .Net reference server but I think this patch is good.

@LarsStegman
Copy link
Contributor Author

That's great! Thank you.

@magiconair magiconair added this to the v0.3.5 milestone Jun 15, 2022
@magiconair magiconair merged commit ad98a1d into gopcua:main Jun 15, 2022
@magiconair
Copy link
Member

Released as v0.3.5

@LarsStegman LarsStegman deleted the fix-rsa-oaep-enc-uri branch June 15, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging this pull request may close these issues.

UserIdentityToken EncryptionAlgorithm RSA-OAEP-SHA1 uses non-existent URL
3 participants
@LarsStegman @magiconair @dwhutchison