refactor: cloudinary driver for goravel #4
Conversation
|
Please add the |
cloudinary.go
Outdated
| func (r *Cloudinary) getResourceType(path string) string { | ||
| extension := strings.TrimPrefix(filepath.Ext(path), ".") | ||
| value := "image" | ||
| resourceTypes := r.config.Get(fmt.Sprintf("filesystems.disks.%s.resource_types", r.disk), defaultResourcesTypes()).(map[string][]string) |
There was a problem hiding this comment.
There seems to be no change here. Based on the below image or range the ResourceTypes. What's your choice?
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
| ResourceType: r.getResourceType(path), | ||
| }) | ||
| // TODO: Search if there is a better way to get asset info | ||
| assetTypes := []api.AssetType{api.Image, api.Video, api.File} |
There was a problem hiding this comment.
Q: Why is there no api.Raw?
There was a problem hiding this comment.
api.File is actually api.Raw.
There was a problem hiding this comment.
Why?
They have defined it in this way:)
https://github.com/cloudinary/cloudinary-go/blob/main/api/api.go#L82
| } | ||
|
|
||
| // PutFileAs stores a new file on the disk. | ||
| func (r *Cloudinary) PutFileAs(path string, source filesystem.File, name string) (string, error) { | ||
| uploadResult, err := r.instance.Upload.Upload(r.ctx, source.File(), uploader.UploadParams{ | ||
| Folder: validPath(path), | ||
| PublicID: r.getPublicId(name), | ||
| PublicID: name, |
There was a problem hiding this comment.
Q: Can the name contain extension?
There was a problem hiding this comment.
If you are following cloudinary then u shouldn't but it won't give any error.
BUT URL OF FILE will contain two file extensions ie .../filename.png.png.
There was a problem hiding this comment.
I think we'd better follow the cloudinary suggestion.
There was a problem hiding this comment.
I think we'd better follow the cloudinary suggestion.
Yeah, we are following cloudinay(user's choice).
Closes #1
📑 Description
This PR will remove unnecessary folders and clean up code-base for review.
✅ Checks