Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resource Route #110

Merged
merged 4 commits into from
Apr 26, 2023
Merged

feat: Resource Route #110

merged 4 commits into from
Apr 26, 2023

Conversation

devhaozi
Copy link
Member

No description provided.

@devhaozi
Copy link
Member Author

Laravel文档中另外几个GET的方法是视图路由，在Goravel中不需要添加。

@devhaozi devhaozi self-assigned this Apr 26, 2023
@devhaozi devhaozi linked an issue Apr 26, 2023 that may be closed by this pull request
✨ [Feature] Add Resources Route goravel/goravel#103
Closed
@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (64e0e09) 54.08% compared to head (8155bd6) 54.13%.

❗ Current head 8155bd6 differs from pull request most recent head e49a990. Consider uploading reports for the commit e49a990 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   54.08%   54.13%   +0.04%     
==========================================
  Files         105      105              
  Lines        7375     7382       +7     
==========================================
+ Hits         3989     3996       +7     
  Misses       3108     3108              
  Partials      278      278
Impacted Files Coverage Δ
route/gin_group.go 95.65% <100.00%> (+0.49%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devhaozi devhaozi enabled auto-merge (squash) April 26, 2023 12:13
@devhaozi devhaozi requested a review from hwbrzzl April 26, 2023 12:14
hwbrzzl
hwbrzzl reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great PR, just a few nitpicks.

contracts/http/context.go Outdated Show resolved Hide resolved
route/gin_group_test.go Outdated Show resolved Hide resolved
route/gin_group_test.go Outdated Show resolved Hide resolved
route/gin_group_test.go Outdated Show resolved Hide resolved
route/gin_group_test.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, by the way, the branch name can be ***/feat-resource-route, like my: bowen/***.

@devhaozi devhaozi merged commit 667cb1e into master Apr 26, 2023
@devhaozi devhaozi deleted the feat-resource-route branch April 26, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees

@devhaozi devhaozi

Labels
✏️ Feature 🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add Resources Route
2 participants
@devhaozi @hwbrzzl