Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add support/path #164

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Conversation

mauri870
Copy link
Contributor

@mauri870 mauri870 commented Jun 4, 2023

Related to: goravel/goravel#82

Functions to be implemented:

  • App path
  • Base path
  • Config path
  • Storage path
  • Public path
  • Database path
  • Resource path
  • Lang path

Lang and Resources can be implemented later.

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39 ⚠️

Comparison is base (39d8766) 53.08% compared to head (5b9e809) 52.70%.

❗ Current head 5b9e809 differs from pull request most recent head 46ac868. Consider uploading reports for the commit 46ac868 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   53.08%   52.70%   -0.39%     
==========================================
  Files         120      119       -1     
  Lines        8513     8368     -145     
==========================================
- Hits         4519     4410     -109     
+ Misses       3677     3647      -30     
+ Partials      317      311       -6     
Impacted Files Coverage Δ
foundation/application.go 65.65% <100.00%> (+2.89%) ⬆️
support/path/path.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mauri870 mauri870 changed the title WIP: Feat: add support/path Feat: add support/path Jun 4, 2023
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@hwbrzzl hwbrzzl enabled auto-merge (squash) June 5, 2023 04:17
@hwbrzzl hwbrzzl merged commit bd31eab into goravel:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants