Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove redis driver for Cache module #172

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 9, 2023

Add a new repository: https://github.com/goravel/redis

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (06ba6d8) 61.31% compared to head (dc4f006) 61.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   61.31%   61.14%   -0.17%     
==========================================
  Files         117      116       -1     
  Lines        7530     7356     -174     
==========================================
- Hits         4617     4498     -119     
+ Misses       2596     2554      -42     
+ Partials      317      304      -13     
Impacted Files Coverage Δ
cache/driver.go 64.28% <ø> (+4.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 79fec06 into master Jun 10, 2023
@devhaozi devhaozi deleted the bowen/split-cache branch June 10, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants