Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Artisan Commands for Generating Controllers, Middlewares, and Models #27

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Adding Artisan Commands for Generating Controllers, Middlewares, and Models #27

merged 2 commits into from
Feb 9, 2023

Conversation

merouanekhalili
Copy link
Contributor

I have implemented the following Artisan commands to simplify the development process:

  • make:controller: generates a new controller with the specified name.
  • make:middleware: generates a new middleware with the specified name.
  • make:model: generates a new model with the specified name.

@merouanekhalili
Adding Artisan Commands for Generating Controllers, Middlewares, and …
23cd9fd 
…Models

I have implemented the following Artisan commands to simplify the development process:
- make:controller: generates a new controller with the specified name.
- make:middleware: generates a new middleware with the specified name.
- make:model: generates a new model with the specified name.
hwbrzzl
hwbrzzl reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great job. Thanks for your PR to perfect Goravel, just left some nitpicks.

database/console/model_make_command.go Outdated Show resolved Hide resolved
database/console/model_make_command_test.go Outdated Show resolved Hide resolved
database/console/model_make_command_test.go Show resolved Hide resolved
database/console/stubs.go Outdated Show resolved Hide resolved
database/console/stubs.go Outdated Show resolved Hide resolved
http/console/middleware_make_command.go Outdated Show resolved Hide resolved
http/console/middleware_make_command.go Outdated Show resolved Hide resolved
http/console/middleware_make_command_test.go Outdated Show resolved Hide resolved
http/console/stubs.go Outdated Show resolved Hide resolved
http/console/stubs.go Outdated Show resolved Hide resolved
@merouanekhalili
Resolve GitHub Pull Request Comment
1884f52 
 This commit resolves the comments made on the GitHub pull request. The changes made address the feedback received and improve the overall quality of the code.
hwbrzzl
hwbrzzl approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, with your contribution, Goravel becomes better.

@hwbrzzl hwbrzzl merged commit d8a5215 into goravel:master Feb 9, 2023
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Dec 18, 2024

Hey @merouanekhalili We created a private channel in Discord for contributors. You can click the link and DM me (@bowen) to join it if you are interested.

Here you can:

  1. Send PR link or review others' PRs;
  2. Discuss new features before creating an issue;
  3. Vote for something;
  4. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merouanekhalili @hwbrzzl