Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize path methods and test workflows #514

Merged
merged 39 commits into from
Jun 18, 2024
Merged

feat: optimize path methods and test workflows #514

merged 39 commits into from
Jun 18, 2024

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Jun 14, 2024

πŸ“‘ Description

Closes https://github.com/goravel/goravel/issues/?

βœ… Checks

  • Added test cases for my code

hwbrzzl
hwbrzzl previously approved these changes Jun 14, 2024
@devhaozi devhaozi enabled auto-merge (squash) June 14, 2024 14:53
hwbrzzl
hwbrzzl previously approved these changes Jun 14, 2024
hwbrzzl
hwbrzzl previously approved these changes Jun 14, 2024
@devhaozi devhaozi changed the title feat: optimize ExecutablePath method feat: optimize path methods Jun 14, 2024
@devhaozi devhaozi closed this Jun 14, 2024
auto-merge was automatically disabled June 14, 2024 15:13

Pull request was closed

@devhaozi devhaozi reopened this Jun 14, 2024
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, left a question

.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
foundation/path.go Outdated Show resolved Hide resolved
@devhaozi devhaozi requested a review from hwbrzzl June 17, 2024 13:31
@devhaozi devhaozi disabled auto-merge June 17, 2024 13:31
@devhaozi devhaozi enabled auto-merge (squash) June 17, 2024 13:31
@devhaozi devhaozi changed the title feat: optimize path methods feat: optimize path methods and test workflows Jun 17, 2024
@devhaozi devhaozi requested a review from hwbrzzl June 17, 2024 15:18
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi
Copy link
Member Author

devhaozi commented Jun 18, 2024

@hwbrzzl Seems I can't merge it, can you help me to it?

@devhaozi devhaozi merged commit 004dda1 into master Jun 18, 2024
10 checks passed
@devhaozi devhaozi deleted the haozi/path branch June 18, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants