fix: session driver lock problem

[devhaozi]

📑 Description

Closes https://github.com/goravel/goravel/issues/?

Summary by CodeRabbit

• Refactor

  • Improved session manager by changing how custom and standard drivers are initialized and assigned.

• Tests

  • Updated and refactored unit tests for better coverage and accuracy with the new session manager implementation.

✅ Checks

• Added test cases for my code

[coderabbitai]

Warning

Rate limit exceeded

@devhaozi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 41 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4c51985 and 0790bec.

Walkthrough

The recent changes focus on modifying the session management system by altering the types of customDrivers and drivers from functions returning sessioncontract.Driver to direct sessioncontract.Driver instances. This simplifies the driver instantiation and management within the Manager struct. Additionally, the test suite has been updated to reflect these modifications, ensuring proper configuration and driver setup.

Changes

File	Change Summary
session/manager.go	Modified customDrivers and drivers types to map[string]sessioncontract.Driver and updated relevant methods.
session/manager_test.go	Updated SetupTest and TestDriver to align with new map types and ensure proper configuration of mock behaviors.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4dc2a25 and 4c51985.

Files selected for processing (2)

• session/manager.go (3 hunks)
• session/manager_test.go (2 hunks)

Additional comments not posted (7)

session/manager.go (5)

14-15: Refactor improves readability and performance.

Changing customDrivers and drivers to directly store sessioncontract.Driver instances simplifies the code and potentially improves performance.

---

22-23: Initialization aligns with refactored struct.

The NewManager function now initializes customDrivers and drivers maps directly with sessioncontract.Driver instances, maintaining consistency with the refactored Manager struct.

---

54-54: Simplified driver retrieval.

The Driver function now directly returns a sessioncontract.Driver instance, improving readability and reducing overhead.

---

58-58: Consistent driver extension.

The Extend function now assigns a sessioncontract.Driver instance directly to customDrivers, maintaining consistency with the refactored Manager struct.

---

72-72: Consistent driver registration.

The registerDrivers function now initializes drivers with sessioncontract.Driver instances, maintaining consistency with the refactored Manager struct.

session/manager_test.go (2)

28-29: Improved test setup.

The SetupTest function now includes specific return values for GetInt and GetString calls, ensuring necessary configuration values are mocked for the tests.

---

34-34: Enhanced driver testing.

The TestDriver function now directly provides the driver name and handles cases where no driver name is provided, improving test coverage for the Driver function.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (4dc2a25) to head (0790bec).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   70.34%   70.34%           
=======================================
  Files         180      180           
  Lines       11212    11212           
=======================================
  Hits         7887     7887           
  Misses       2751     2751           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hwbrzzl]

Great 👍