-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use any
as ctx key
#628
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 69.94% 69.94%
=======================================
Files 184 184
Lines 11296 11296
=======================================
Hits 7901 7901
Misses 2818 2818
Partials 577 577 β View full report in Codecov by Sentry. |
about the mockery check, i had no idea what's wrong with it, do you have any suggestion @hwbrzzl ? and about the lint check, since i didn't touch it in my changes, i have no clue about the error |
@hwbrzzl suggest to set a private token for Mockery to avoid permission problem. |
Thanks PR, I'm checking the mockery error. |
Hey @mdanialr, it seems to be hard to run the Mockery workflow in a fork repo, so could you run the mockery locally? Install mockery: https://vektra.github.io/mockery/latest/installation/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, please also modify the code in goravel/gin and goravel/fiber.
all right let me do it, but i just wondering, why would generated files are included in the source? |
let me check |
For testing |
This PR is a bit different with #630, please update it, then I'll approve. |
π Description
Closes #486
@coderabbitai summary
β Checks