Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use any as ctx key #628

Closed
wants to merge 8 commits into from

Conversation

mdanialr
Copy link

@mdanialr mdanialr commented Sep 7, 2024

πŸ“‘ Description

Closes #486

@coderabbitai summary

βœ… Checks

  • Added test cases for my code

@mdanialr mdanialr requested a review from a team as a code owner September 7, 2024 09:42
Copy link
Contributor

coderabbitai bot commented Sep 7, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • πŸš€ Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 69.94%. Comparing base (9282acc) to head (7c7c791).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   69.94%   69.94%           
=======================================
  Files         184      184           
  Lines       11296    11296           
=======================================
  Hits         7901     7901           
  Misses       2818     2818           
  Partials      577      577           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@mdanialr
Copy link
Author

mdanialr commented Sep 7, 2024

about the mockery check, i had no idea what's wrong with it, do you have any suggestion @hwbrzzl ?

and about the lint check, since i didn't touch it in my changes, i have no clue about the error

@devhaozi
Copy link
Member

devhaozi commented Sep 7, 2024

@hwbrzzl suggest to set a private token for Mockery to avoid permission problem.

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 8, 2024

Thanks PR, I'm checking the mockery error.

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 9, 2024

Hey @mdanialr, it seems to be hard to run the Mockery workflow in a fork repo, so could you run the mockery locally?

Install mockery: https://vektra.github.io/mockery/latest/installation/
Then run the command: mockery

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please also modify the code in goravel/gin and goravel/fiber.

http/context_test.go Show resolved Hide resolved
@mdanialr
Copy link
Author

mdanialr commented Sep 9, 2024

Hey @mdanialr, it seems to be hard to run the Mockery workflow in a fork repo, so could you run the mockery locally?

Install mockery: https://vektra.github.io/mockery/latest/installation/ Then run the command: mockery

all right let me do it, but i just wondering, why would generated files are included in the source?

@mdanialr
Copy link
Author

mdanialr commented Sep 9, 2024

Looks great, please also modify the code in goravel/gin and goravel/fiber.

let me check

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 9, 2024

Hey @mdanialr, it seems to be hard to run the Mockery workflow in a fork repo, so could you run the mockery locally?
Install mockery: https://vektra.github.io/mockery/latest/installation/ Then run the command: mockery

all right let me do it, but i just wondering, why would generated files are included in the source?

For testing

@mdanialr mdanialr requested a review from hwbrzzl September 12, 2024 13:26
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 12, 2024

This PR is a bit different with #630, please update it, then I'll approve.

@mdanialr
Copy link
Author

This PR is a bit different with #630, please update it, then I'll approve.

done in 7c7c791

@mdanialr mdanialr closed this Sep 13, 2024
@mdanialr mdanialr deleted the feat/ctx-key-to-any branch September 13, 2024 04:45
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Dec 18, 2024

Hey @mdanialr We created a private channel in Discord for contributors. You can click the link and DM me (@bowen) to join it if you are interested.

Here you can:

  1. Send PR link or review others' PRs;
  2. Discuss new features before creating an issue;
  3. Vote for something;
  4. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Change the key type of ctx.WithValue to any
3 participants