feat: [#540] Remove contracts/database/config.go::Driver #823
Conversation
|
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for "github.com/goravel/framework/database/schema/constants"" WalkthroughThis pull request introduces significant changes to the Goravel framework's database and schema management infrastructure. The changes primarily involve removing multiple database-specific implementations for MySQL, SQLite, and SQL Server, simplifying the driver handling, and updating various components to use string-based driver representations. Additionally, new GitHub Actions workflows have been added for PR title checking and external testing. Changes
Sequence DiagramsequenceDiagram
participant Client
participant GormQuery
participant Driver
participant Query
Client->>Driver: Gorm()
Driver-->>Client: db, gormQuery, error
Client->>Query: Initialize with gormQuery
Query->>GormQuery: Use methods like LockForUpdate()
GormQuery-->>Query: Return query expression
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (56)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 65.19% 67.06% +1.86%
==========================================
Files 150 147 -3
Lines 10694 10396 -298
==========================================
Hits 6972 6972
+ Misses 3349 3051 -298
Partials 373 373 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: bca1922 | Previous: cdd2b8b | Ratio |
|---|---|---|---|
Benchmark_DecryptString |
5665 ns/op 1592 B/op 17 allocs/op |
3091 ns/op 1592 B/op 17 allocs/op |
1.83 |
Benchmark_DecryptString - ns/op |
5665 ns/op |
3091 ns/op |
1.83 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Because it's blocking my another PR and there is no logic change, only replacing |
📑 Description
Summary by CodeRabbit
Based on the comprehensive summary of changes, here are the concise release notes:
GitHub Actions
Database Enhancements
GormQueryinterface for more flexible database query handlingTesting Improvements
Dependency Management
Code Refactoring
✅ Checks