-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [#358] Add connection method for DB #909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
=======================================
Coverage 68.01% 68.01%
=======================================
Files 154 154
Lines 10192 10192
=======================================
Hits 6932 6932
Misses 2934 2934
Partials 326 326 ☔ View full report in Codecov by Sentry. |
Caution Review failedThe pull request is closed. WalkthroughThe pull request updates the database interface and implementation to enhance connection handling and introduce groundwork for transaction management. A new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant DB
participant BuildDB
participant Log
Client->>DB: Call Connection(name)
alt Connection exists in cache
DB-->>Client: Return cached connection
else Connection does not exist
DB->>BuildDB: Invoke BuildDB(ctx, config, log, connection)
BuildDB-->>DB: Return new connection instance
alt Error Occurs
DB->>Log: Log panic message
end
DB-->>Client: Return new connection
end
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0) 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📑 Description
goravel/goravel#358
Summary by CodeRabbit
New Features
Refactor
Tests
✅ Checks