Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sqlite driver to github.com/glebarez/go-sqlite #91

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Change sqlite driver to github.com/glebarez/go-sqlite #91

merged 9 commits into from
Apr 18, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi
Copy link
Member Author

这个冲突是github.com/glebarez/go-sqlite修改了modernc.org/sqlite导致的,寻找解决方案中...

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b37b9bd) 51.55% compared to head (d21cd80) 51.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      goravel/framework#91   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files         103      103           
  Lines        7032     7032           
=======================================
  Hits         3625     3625           
  Misses       3126     3126           
  Partials      281      281           
Impacted Files Coverage Δ
database/gorm/dialector.go 71.69% <ø> (ø)
database/console/migrate.go 46.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 目录可以改为 driver/sqlite => driver

database/console/driver/sqlite/sqlite.go Outdated Show resolved Hide resolved
database/console/driver/sqlite/README.md Outdated Show resolved Hide resolved
database/console/driver/sqlite/sqlite.go Outdated Show resolved Hide resolved
@devhaozi devhaozi requested a review from hwbrzzl April 18, 2023 02:45
@devhaozi
Copy link
Member Author

也许回头可以把这个驱动也提交给golang-migrate,就不需要自定义了。不知道他们接不接受。

@devhaozi devhaozi requested a review from hwbrzzl April 18, 2023 02:55
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@hwbrzzl hwbrzzl merged commit 0c82fe9 into goravel:master Apr 18, 2023
@devhaozi devhaozi deleted the sqlite branch April 18, 2023 03:06
@devhaozi devhaozi changed the title Change sqlite driver to modernc.org/sqlite Change sqlite driver to github.com/glebarez/go-sqlite Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 使用github.com/glebarez/go-sqlite替代github.com/mattn/go-sqlite3
2 participants