Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add custom module name #27

Merged
merged 6 commits into from
Mar 6, 2025
Merged

feat: Add custom module name #27

merged 6 commits into from
Mar 6, 2025

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented Mar 4, 2025 •
edited
Loading

📑 Description

Closes goravel/goravel#617

Related SS

image
image
image
image

✅ Checks

  • Added test cases for my code

hwbrzzl
hwbrzzl reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Could you test this locally and paste screenshots in the description?

@kkumar-gcc kkumar-gcc changed the title Add custom module name feat: Add custom module name Mar 5, 2025
hwbrzzl
hwbrzzl reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can modify the version in this PR directly, I'll release a new version.

hwbrzzl
hwbrzzl reviewed Mar 5, 2025
View reviewed changes
hwbrzzl
hwbrzzl approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 👍

@kkumar-gcc kkumar-gcc merged commit b84626c into master Mar 6, 2025
7 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#617 branch March 6, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Custom Module Name in Installer
2 participants
@kkumar-gcc @hwbrzzl