-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: processing symlinks in directories #453
Conversation
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 65.89% 65.93% +0.03%
==========================================
Files 16 16
Lines 1903 1905 +2
==========================================
+ Hits 1254 1256 +2
Misses 510 510
Partials 139 139
Continue to review full report at Codecov.
|
Woop-woop, it's green :-j |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I would keep the symlink tests in each packager too
Then I'd rather just put the static links and see if it's there, without helpers and creating. On one hand. On another hand, there are still tests though https://github.com/goreleaser/nfpm/blob/main/apk/apk_test.go#L477, https://github.com/goreleaser/nfpm/blob/main/rpm/rpm_test.go#L641, and https://github.com/goreleaser/nfpm/blob/main/deb/deb_test.go#L685 Removed tests were there for particular checking if the destination files in archives are the same as the target files for symlinks. And this logic is completely dead now. upd: the coverage report shows, that I haven't removed any tests that did check for anything |
Dear @erikgeiser and @djgilcrease, can you review it too, please? Would be very helpful to have it merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me,
Thanks everyone! |
Thank you, awesome! I am looking forward to a new release! |
This PR fixes #428 and depends on goreleaser/fileglob#24
appendGlobbedFiles
now distinguish symlinks and add a properContent
object.Tests in
deb
andrpm
are removed because covered byfiles
now.I'll update the go.mod and convert it from the draft after the mentioned PR is merged.