Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe 1st-party vs 3rd-party for images / CSS, not just scripts? #484

Closed
wolftune opened this issue Jul 11, 2015 · 6 comments
Closed

Maybe 1st-party vs 3rd-party for images / CSS, not just scripts? #484

wolftune opened this issue Jul 11, 2015 · 6 comments

Comments

@wolftune
Copy link

As an advanced user, I thought that block-all by default would replace requestpolicy smoothly. It's close, but I seem to be blocking CSS and images for 1st-party sites, so that 99% of sites are broken, even those that don't rely on 3rd-parties or JavaScript.

I think it would be ideal to have separate 1st-party vs 3rd-party options for images and CSS.

Here's the real issue: there seems to be no setting to block all 3rd-party images but not block 1st-party, and also, there's a bug where I can go to a very plain site (such as https://www.seas.upenn.edu/~cis194/spring13/ ) and the layout itself is broken if I default to block all, but the layout works correct if I block every one of the other thing to block (images, scripts, scripts and frames of all sorts). So, blocking all is blocking extra 1st-party stuff that isn't separately categorized among the general options… I'm unclear what it is that is extra to block (CSS I suppose). I don't want to block 1st-party CSS, but I'm unsure whether blocking all is otherwise blocking anything else I'd like to block, since I'm unsure the total list of non-blocked things when all general options except for "all" are set to block…

@gorhill
Copy link
Owner

gorhill commented Jul 11, 2015

I personally do not see all as very being very useful. Why not use 3rd-party? That's what I use, and that's what RP does if I am not mistaken.

a

@TeddStriker
Copy link

Using the site you posted, blocking all does break the site. And there's no option to allow CSS/Images only for the first party.

However, and @gorhill can correct me if I'm mistaken, I think uBlock wasn't meant to allow such precise options, I think you're looking for functionality uMatrix has to offer.

This is all under the assumption that I understood what you were trying to say correctly, if not, I apologize.

@wolftune
Copy link
Author

Thanks, I guess I was being over-cautious. I think that 3rd-party is all I really need when combined with static-filters. @gorhill is the reason 3rd-party scripts not blocked in your screenshot because you use NoScript for that?

@gorhill
Copy link
Owner

gorhill commented Jul 12, 2015

3rd-party scripts not blocked in your screenshot because you use NoScript for that?

They are blocked, through 3rd-party cell.

@wolftune
Copy link
Author

@gorhill okay, so last question then: is it an inconsistency in the UI versus the backend that marking "3rd-party" as blocked doesn't create a light-red indication for "3rd-party scripts" and "3rd-party frames"?

@gorhill
Copy link
Owner

gorhill commented Jul 12, 2015

is it an inconsistency in the UI versus the backend that marking "3rd-party" as blocked doesn't create a light-red indication for "3rd-party scripts" and "3rd-party frames"?

Yes, ideally they should light up in sync with the 3rd-party cell unless they have their own rules. The matrix coloring uses the same code paths as the request evaluation. I am sure I wanted this originally but it was not as straightforward as thought back then.

Edit: Feel free to open an issue for this quirk. Looking at the code I can see why it's not as straightforward, but nothing that can't be fixed with having a specific code path for matrix coloring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants