Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic 3rd-party switch does not indicate 3rd-party scripts and frames are blocked #2171

Closed
2 tasks done
lhindir opened this issue Jul 14, 2022 · 4 comments
Closed
2 tasks done
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@lhindir
Copy link

lhindir commented Jul 14, 2022

Prerequisites

Description

According to gorhill/uBlock#484 (comment), using the dynamic filtering matrix to block generic 3rd-party requests includes 3rd-party scripts and frames on the backend, but the UI does not reflect this by having the scripts and frames rows inherit the red or gray fills.

Steps to Reproduce

  1. Block 3rd-party requests locally or globally using the matrix UI
  2. Note the 3rd-party scripts and frames rows do not inherit the red fill

uBlock Origin version

1.43.0

Browser name and version

Firefox 102.0

@gorhill
Copy link
Member

gorhill commented Jul 14, 2022

Note the 3rd-party scripts and frames rows do not inherit the red fill

Yes by design: filling in red would suggest all is being blocked when it's only 3rd-party frames and/or 3rd-party scripts. Other types of resources are not being blocked.

I do agree that the block rules should be conveyed somehow, and that is gorhill/uBlock#544. I did some work on this months ago (using partially filled cells), but I was not satisfied with the results, so still an open issue.

@gorhill gorhill closed this as completed Jul 14, 2022
@gorhill gorhill added the duplicate This issue or pull request already exists label Jul 14, 2022
@lhindir
Copy link
Author

lhindir commented Jul 14, 2022

Note the 3rd-party scripts and frames rows do not inherit the red fill

Yes by design: filling in red would suggest all is being blocked when it's only 3rd-party frames and/or 3rd-party scripts. Other types of resources are not being blocked.

I’m confused. I’m referring to using the row simply labeled “3rd-party” to block or no-op all 3rd-party requests. Based on the comment I linked, it looks like that action includes blocking 3rd-party frames and scripts, but the UI does not reflect it.

Screenshot from 2022-07-14 11-36-14

Shouldn’t the rows labeled “3rd-party scripts” and “3rd-party frames” have the same translucent red fill indicating inheritance that the bottom rows do?

@gorhill gorhill reopened this Jul 14, 2022
@gorhill
Copy link
Member

gorhill commented Jul 14, 2022

Ok I see what you mean, I misunderstood.

@gwarser gwarser added enhancement New feature or request and removed duplicate This issue or pull request already exists labels Jul 14, 2022
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 15, 2022
@gwarser gwarser added the fixed issue has been addressed label Jul 15, 2022
@gwarser gwarser closed this as completed Jul 15, 2022
@lhindir
Copy link
Author

lhindir commented Jul 16, 2022

Maybe it goes without saying, but thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants