Links now only update after publish and unpublish

gorriecoe · Apr 9, 2020 · 9b95b58 · 9b95b58
1 parent b838921
commit 9b95b58
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 18 deletions.
diff --git a/src/extensions/SiteTreeAutoCreateExtension.php b/src/extensions/SiteTreeAutoCreateExtension.php
@@ -5,7 +5,6 @@
 use gorriecoe\Menu\Models\MenuSet;
 use gorriecoe\Menu\Models\MenuLink;
 use SilverStripe\ORM\ArrayList;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataExtension;
 
 /**
@@ -36,19 +35,13 @@ public function getOwnsMenu()
     }
 
     /**
-     * Event handler called after writing to the database.
+     * Event handler called after Publishing to the live sitetree.
      */
-    public function onAfterWrite()
+    public function onAfterPublish()
     {
-        parent::onAfterWrite();
         $owner = $this->owner;
-
-        foreach ($this->getOwnsMenu() as $menuSet) {
-            $menuLink = DataObject::get_one(MenuLink::class, [
-                'Type' => 'SiteTree', // Ensures the editor hasn't intentionally changed this link.
-                'MenuSetID' => $menuSet->ID,
-                'SiteTreeID' => $owner->ID
-            ]);
+        foreach ($owner->OwnsMenu as $menuSet) {
+            $menuLink = MenuLink::get_by_sitetreeID($menuSet, $owner->ID);
             if ($menuLink) {
                 $menuLink->setField('Title', $owner->MenuTitle);
             } else {
@@ -62,20 +55,29 @@ public function onAfterWrite()
         }
     }
 
+    /**
+     * Event handler called before unpublishing from live sitetree.
+     */
+    public function onBeforeUnpublish()
+    {
+        $owner = $this->owner;
+        foreach ($owner->OwnsMenu as $menuSet) {
+            $menuLink = MenuLink::get_by_sitetreeID($menuSet, $owner->ID);
+            if ($menuLink) {
+                $menuLink->delete();
+            }
+        }
+    }
+
     /**
      * Event handler called before deleting from the database.
      */
     public function onBeforeDelete()
     {
-        parent::onBeforeDelete();
         $owner = $this->owner;
 
-        foreach ($this->getOwnsMenu() as $menuSet) {
-            $menuLink = DataObject::get_one(MenuLink::class, [
-                'Type' => 'SiteTree',
-                'MenuSetID' => $menuSet->ID,
-                'SiteTreeID' => $owner->ID
-            ]);
+        foreach ($owner->OwnsMenu as $menuSet) {
+            $menuLink = MenuLink::get_by_sitetreeID($menuSet, $owner->ID);
             if ($menuLink) {
                 $menuLink->delete();
             }

diff --git a/src/models/MenuLink.php b/src/models/MenuLink.php
@@ -3,12 +3,14 @@
 namespace gorriecoe\Menu\Models;
 
 use gorriecoe\Link\Models\Link;
+use gorriecoe\Menu\Models\MenuSet;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\GridField\GridField;
 use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
 use SilverStripe\GraphQL\Scaffolding\Interfaces\ScaffoldingProvider;
 use SilverStripe\GraphQL\Scaffolding\Scaffolders\SchemaScaffolder;
 use SilverStripe\ORM\HasManyList;
+use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\Member;
 use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
 
@@ -231,4 +233,27 @@ public function provideGraphQLScaffolding(SchemaScaffolder $scaffolder)
             ->end();
         return $scaffolder;
     }
+
+    /**
+     * Return the first menulink matching the given MenuSet and SiteTreeID.
+     *
+     * @param gorriecoe\Menu\Models\MenuSet|String
+     * @param Int
+     *
+     * @return gorriecoe\Menu\Models\MenuLink|Null
+     */
+    public static function get_by_sitetreeID($menuSet, Int $siteTreeID)
+    {
+        if (!$menuSet instanceof MenuSet) {
+            $menuSet = MenuSet::get_by_slug($menuSet);
+        }
+        if (!$menuSet) {
+            return;
+        }
+        return DataObject::get_one(self::class, [
+            'Type' => 'SiteTree', // Ensures the admin hasn't intentionally changed this link
+            'MenuSetID' => $menuSet->ID,
+            'SiteTreeID' => $siteTreeID
+        ]);
+    }
 }