Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to v2 addon #22

Merged
merged 8 commits into from
Jul 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .eslintrc.js

This file was deleted.

146 changes: 90 additions & 56 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# This workflow is largely based on
# https://github.com/salsify/ember-css-modules/blob/master/.github/workflows/ci.yml

name: PR

# These trigger patterns courtesy of https://github.com/broccolijs/broccoli/pull/436
on:
workflow_dispatch:
pull_request:
Expand All @@ -12,65 +8,103 @@ env:
CI: true

jobs:
# build:
# runs-on: ubuntu-latest
# steps:
# - name: Setup
# uses: wyvox/action@v1
# - name: Build
# run: pnpm --filter ember-command run build

lint-js:
name: lint:js
runs-on: ubuntu-latest
steps:
- name: Setup
uses: wyvox/action@v1
- name: Build
run: pnpm --filter ember-command run build
- run: pnpm run -r --parallel --aggregate-output lint:js

lint-hbs:
name: lint:hbs
runs-on: ubuntu-latest
steps:
- name: Setup
uses: wyvox/action@v1
- name: Build
run: pnpm --filter ember-command run build
- run: pnpm run -r --parallel --aggregate-output lint:hbs

lint-types:
name: lint:types
runs-on: ubuntu-latest
steps:
- name: Setup
uses: wyvox/action@v1
- name: Build
run: pnpm --filter ember-command run build
- run: pnpm run -r --parallel --aggregate-output lint:types

test-locked-deps:
name: Locked Deps
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
- name: Install Node
uses: actions/setup-node@v2
with:
node-version: 16
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Setup
uses: wyvox/action@v1
- name: Build package
run: pnpm --filter ember-command build
- name: Lint JS
run: yarn lint:js
run: pnpm run -r --parallel --aggregate-output lint:js
- name: Lint Types
run: yarn lint:types
run: pnpm run -r --parallel --aggregate-output lint:types
- name: Lint Handlebars
run: yarn lint:hbs
- name: Browser Tests
run: yarn test:ember
run: pnpm run -r --parallel --aggregate-output lint:hbs
- name: Tests
run: pnpm run -r --parallel --aggregate-output test

test-old-dependencies:
name: Oldest Supported Env
runs-on: ubuntu-20.04
test-floating-deps:
name: Floating Deps
runs-on: ubuntu-lates
steps:
- name: Checkout Code
uses: actions/checkout@v2
- name: Install Node
uses: actions/setup-node@v2
- name: Setup
uses: wyvox/action@v1
with:
node-version: 12
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Browser Tests
run: yarn test:ember
pnpm-args: --no-frozen-lockfile
- name: Build package
run: pnpm --filter ember-command build
- name: Lint JS
run: pnpm run -r --parallel --aggregate-output lint:js
- name: Lint Types
run: pnpm run -r --parallel --aggregate-output lint:types
- name: Lint Handlebars
run: pnpm run -r --parallel --aggregate-output lint:hbs
- name: Tests
run: pnpm run -r --parallel --aggregate-output test

test-try:
name: Ember Try
runs-on: ubuntu-20.04
needs: [test-locked-deps]
strategy:
matrix:
scenario:
- ember-lts-3.20
- ember-lts-3.24
- ember-4.0.0
- ember-release
- ember-beta
- ember-canary
- embroider-safe
- embroider-optimized
steps:
- name: Checkout Code
uses: actions/checkout@v2
- name: Install Node
uses: actions/setup-node@v2
with:
node-version: 16
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Try Scenario
run: yarn ember try:one ${{ matrix.scenario }}
# test-try:
# name: Ember Try
# runs-on: ubuntu-20.04
# needs: [test-locked-deps]
# strategy:
# matrix:
# scenario:
# - ember-lts-3.20
# - ember-lts-3.24
# - ember-4.0.0
# - ember-release
# - ember-beta
# - ember-canary
# - embroider-safe
# - embroider-optimized
# steps:
# - name: Checkout Code
# uses: actions/checkout@v2
# - name: Install Node
# uses: actions/setup-node@v2
# with:
# node-version: 16
# - name: Install Dependencies
# run: yarn install --frozen-lockfile
# - name: Try Scenario
# run: yarn ember try:one ${{ matrix.scenario }}
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# compiled output
/dist/
/tmp/
declarations/

# dependencies
/bower_components/
Expand All @@ -23,4 +24,10 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try

# broccoli-debug
/DEBUG/
33 changes: 0 additions & 33 deletions .npmignore

This file was deleted.

6 changes: 6 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
public-hoist-pattern[]=*prettier*
public-hoist-pattern[]=*eslint*
public-hoist-pattern[]=!@typescript-eslint/*
public-hoist-pattern[]=*ember-template-lint*
public-hoist-pattern[]=*stylelint*
strict-peer-dependencies=false
15 changes: 0 additions & 15 deletions .prettierrc

This file was deleted.

5 changes: 0 additions & 5 deletions .template-lintrc.js

This file was deleted.

15 changes: 15 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"[glimmer-ts]": {
"editor.formatOnSave": true,
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
},
"eslint.workingDirectories": [
{
"mode": "auto"
}
]
// [
// "ember-command",
// "test-app"
// ]
}
4 changes: 0 additions & 4 deletions addon-test-support/.eslintrc.js

This file was deleted.

62 changes: 0 additions & 62 deletions addon-test-support/index.ts

This file was deleted.

3 changes: 0 additions & 3 deletions addon/-private/command.ts

This file was deleted.

7 changes: 0 additions & 7 deletions addon/-private/commandables.ts

This file was deleted.

8 changes: 0 additions & 8 deletions addon/-private/link-command.ts

This file was deleted.

4 changes: 0 additions & 4 deletions addon/.eslintrc.js

This file was deleted.

16 changes: 0 additions & 16 deletions addon/components/command-element/index.hbs

This file was deleted.

Loading