Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: use golang.org/x/sys to detect Terminal #112

Merged
merged 2 commits into from
May 16, 2020
Merged

Windows: use golang.org/x/sys to detect Terminal #112

merged 2 commits into from
May 16, 2020

Conversation

thaJeztah
Copy link
Contributor

No description provided.

@thaJeztah
Copy link
Contributor Author

@dnephin ptal

(looks like it's still used by other dependencies though)

@dnephin
Copy link
Member

dnephin commented May 16, 2020

Ya, looks to be still used by github.com/fatih/color

@dnephin dnephin force-pushed the detect_terminal branch from f7b34a4 to f722162 Compare May 16, 2020 18:56
@dnephin
Copy link
Member

dnephin commented May 16, 2020 •
edited
Loading

Thanks! I rebased to remove the merge conflict, and updated another dependency while I was at it

@dnephin dnephin merged commit eae3dbf into gotestyourself:master May 16, 2020
@thaJeztah
Copy link
Contributor Author

Thanks! Have one more thing that looks like it can be replaced; let me push that

@thaJeztah thaJeztah deleted the detect_terminal branch May 16, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @dnephin