Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update goreleaser 1.7.0 to 1.17.0 for windows/arm64 #324

Merged
merged 1 commit into from
Apr 13, 2023
Merged

ci: update goreleaser 1.7.0 to 1.17.0 for windows/arm64 #324

merged 1 commit into from
Apr 13, 2023

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Apr 12, 2023 •
edited
Loading

Close #323

I've confirmed the issue has been solved by updating goreleaser in my laptop.

$ goreleaser --version
goreleaser version 1.17.0
commit: ffefd6c4ae257d2e9aeccb5786ba66401cc1bd78
built at: 2023-04-10T11:56:39Z
built by: goreleaser
goos: darwin
goarch: arm64
module version: v1.17.0, checksum: h1:CcA7EOcljdYhpEY2MUI1je6swCTCAlubxZk1VCbPKBY=

https://goreleaser.com
$ goreleaser --clean --snapshot --config .project/goreleaser.yml
  • starting release...
  • loading config file                              file=.project/goreleaser.yml
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=6723d7d1d70e3e77d1032a027b3d87b8fb88be2d latest tag=v1.10.0
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=1.10.0-SNAPSHOT-6723d7d
  • checking distribution directory
    • cleaning dist
  • loading go mod information
    • took: 1s
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/gotestsum_linux_arm_6/gotestsum
    • building                                       binary=dist/gotestsum_windows_amd64_v1/gotestsum.exe
    • building                                       binary=dist/gotestsum_windows_arm_6/gotestsum.exe
    • building                                       binary=dist/gotestsum_linux_amd64_v1/gotestsum
    • building                                       binary=dist/gotestsum_linux_arm64/gotestsum
    • building                                       binary=dist/gotestsum_darwin_arm64/gotestsum
    • building                                       binary=dist/gotestsum_darwin_amd64_v1/gotestsum
    • building                                       binary=dist/gotestsum_freebsd_arm64/gotestsum
    • building                                       binary=dist/gotestsum_windows_arm64/gotestsum.exe
    • building                                       binary=dist/gotestsum_freebsd_amd64_v1/gotestsum
    • building                                       binary=dist/gotestsum_linux_s390x/gotestsum
    • building                                       binary=dist/gotestsum_linux_ppc64le/gotestsum
    • took: 4s
  • archives
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_windows_arm64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_freebsd_arm64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_darwin_arm64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_darwin_amd64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_windows_amd64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_linux_amd64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_linux_arm64.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_linux_ppc64le.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_linux_armv6.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_linux_s390x.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_windows_armv6.tar.gz
    • creating                                       archive=dist/gotestsum_1.10.0-SNAPSHOT-6723d7d_freebsd_amd64.tar.gz
    • took: 1s
  • calculating checksums
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 5s

The warning was disappeared and the asset for windows/arm64 was built.

$ ls dist/gotestsum_windows_arm64/gotestsum.exe
dist/gotestsum_windows_arm64/gotestsum.exe

@suzuki-shunsuke
ci: update goreleaser 1.7.0 to 1.17.0 for windows/arm64
f78ec13 
- #323

I've confirmed the issue has been solved by updating goreleaser in my laptop.

```
goreleaser --clean --snapshot --config .project/goreleaser.yml
```
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Apr 12, 2023
Closed
suzuki-shunsuke
suzuki-shunsuke commented Apr 12, 2023
View reviewed changes
.circleci/config.yml
@@ -98,13 +98,13 @@ jobs:
steps:
run:
name: build binaries
command: bin/goreleaser --rm-dist --snapshot --config .project/goreleaser.yml
command: bin/goreleaser --clean --snapshot --config .project/goreleaser.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--rm-dist was deprecated.
https://goreleaser.com/deprecations/#-rm-dist

suzuki-shunsuke
suzuki-shunsuke commented Apr 12, 2023
View reviewed changes
.circleci/config.yml
@@ -68,8 +68,8 @@ commands:
- run:
name: Install goreleaser
command: |
wget https://github.com/goreleaser/goreleaser/releases/download/v1.7.0/goreleaser_Linux_x86_64.tar.gz
echo "e74934e7571991522324642ac7b032310f04baf192ce2a54db1dc323b97bcd7d goreleaser_Linux_x86_64.tar.gz" > checksum.txt
wget https://github.com/goreleaser/goreleaser/releases/download/v1.17.0/goreleaser_Linux_x86_64.tar.gz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/goreleaser/goreleaser/releases/tag/v1.17.0

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review April 12, 2023 03:05
dnephin
dnephin approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@dnephin dnephin merged commit 90a35cf into gotestyourself:main Apr 13, 2023
@suzuki-shunsuke suzuki-shunsuke deleted the ci/update-goreleaser-for-windows-arm64 branch April 13, 2023 22:20
@Porkepix Porkepix mentioned this pull request Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The release for windows/arm64 was skipped
2 participants
@suzuki-shunsuke @dnephin