Allow giving param names to globs thus allowing multiple #437
Conversation
| @@ -25,7 +25,7 @@ hyper = "0.13.1" | |||
| serde = "1.0" | |||
| serde_derive = "1.0" | |||
| bincode = "1.0" | |||
| mime = "0.3" | |||
| mime = "0.3.15" | |||
There was a problem hiding this comment.
I did this because we are using Mime::essence_str() which is not available in <3.15
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 106 106
Lines 5224 5281 +57
=======================================
+ Hits 4399 4447 +48
- Misses 825 834 +9
Continue to review full report at Codecov.
|
| [patch.crates-io] | ||
| gotham = { path = "gotham" } | ||
| gotham_derive = { path = "gotham_derive" } | ||
| borrow-bag = { path = "misc/borrow_bag" } |
There was a problem hiding this comment.
Could you restore this, please? For development, it's certainly easier to use these together, rather than publishing individually.
There was a problem hiding this comment.
This is not needed anymore because Cargo supports both path and version in dependencies which I added in a previous PR. I missed one spot and I fixed it in this PR.
There was a problem hiding this comment.
And since cargo doesn't support publishing all packages at once, you can use https://crates.io/crates/cargo-workspaces to do it which works with path and version in dependencies without this being needed.
There was a problem hiding this comment.
@nyarly Can you please reply to this comment? I want to get this PR resolved.
|
Also, I'd quibble that the one feature eveyone overlooks in Rails is bi-directional routing. Although it's interface is overbroad, being able to use the |
I agree but I don't understand why we are talking about this. Was there something related in this PR? |
It's in reply to "This was the only deficiency in gotham when compared to Rails router." Not an issue with the change. |
@colinbankier @nyarly As you guys know, I had recently published this blog post comparing routing capabilities.
This was the only deficiency in gotham when compared to Rails router. So, I fixed it.