Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop handling the case when foo.Spec.Replicas is nil #1

Closed

Conversation

shuheiktgw
Copy link

Sorry for nitpicking but I believe we don't need to handle the case when foo.Spec.Replicas is nil since foo.Spec.Replicas is required is a required field and cannot be nil 😄

@govargo
Copy link
Owner

govargo commented Nov 30, 2020

Thank you for this PR.

I added this case because the code of some branches removed this required marker.

e.g.
https://github.com/govargo/foo-controller-kubebuilder/blob/admission_webhook/api/v1alpha1/foo_types.go#L33-L36
https://github.com/govargo/foo-controller-kubebuilder/blob/multi_conversion/api/v1alpha1/foo_types.go#L33-L36

This is why it was necessary for some cases to match the story flow of the book.

@shuheiktgw
Copy link
Author

@govargo So sorry for not noticing your comment 🙇
That makes sense so let me close this PR!

@shuheiktgw shuheiktgw closed this Dec 27, 2020
@shuheiktgw shuheiktgw deleted the remove_default_replicas branch December 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants