-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve language consistency #148
Conversation
<tr> | ||
<td class="tg-ycr8"><span style="font-weight:400;font-style:normal;text-decoration:none;color:#000">Authentication and <code>P2</code> (or higher) identity assurance</span></td> | ||
<td class="tg-ycr8"><span style="font-weight:400;font-style:normal;text-decoration:none;color:#000">You can request user attributes using both claims and scopes (or either claims or scopes, depending on what your service needs).</span></td> | ||
<td class="tg-ycr8"><span style="font-weight:400;font-style:normal;text-decoration:none;color:#000">Authentication and identity confidence</span></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this change - I thought authentication only could not use claims?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't offer P1 at the moment, Phil suggested to take that line out, and replace the P2 line with Auth + Identity, since you can only request scopes with auth, but with auth + identity you can choose scopes and/or claims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we stuck with confidence here, because we are describing the concept, however, I am thinking we probably want to stay consistent and actually change it to proving after all, as we are talking about the type of request, and we refer elsewhere to auth and auth+identity, which is bringing us back to the core reason for having this PR. Would that make more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Why and what
There are several terms that would be good to use more consistently throughout the pages. For example 'authorisation' can be used in the American or the British spelling because the OIDC definition uses the American spelling to describe the concepts. Another example is 'identity proving', as there are various words used in the standards to describe this. To ensure readers know that we are not talking about different concepts, we want to make sure we are using consistent language throughout.
Technical writer support
Do you need a tech writer's support, for example to review your PR?
How to review
Tell reviewers how to assess your changes.