Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant GOV.UK PaaS files #158

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Remove redundant GOV.UK PaaS files #158

merged 2 commits into from
Jan 26, 2024

Conversation

pauldougan
Copy link
Contributor

@pauldougan pauldougan commented Jan 25, 2024 •
edited
Loading

Why

The docs used to be hosted on GOV.UK PaaS but is now migrated to AWS ECS and there is some residual junk left over that is redundant.

What

delete Staticfile and manifest.yml

Technical writer support

Do you need a tech writer's support, for example to review your PR? - no

How to review

  • Ensure it still runs locally using the local ruby
  • Ensure it still runs locally using Docker

@pauldougan pauldougan added the housekeeping keeping the house in order label Jan 25, 2024
@pauldougan pauldougan linked an issue Jan 25, 2024 that may be closed by this pull request
Remove the manifest.yaml file which is a relic deplying to the defunct GOV.UK PaaS #149
Closed
@pauldougan
Copy link
Contributor Author

Hey @elenaschwan one final merge ...

huwd
huwd approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@huwd huwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a bit of rebuild troubles, but moment I rebased against main it went away.
I think that's just based on the older branch we've spun off here.

So looks good to me

@huwd
Copy link
Contributor

huwd commented Jan 26, 2024

@pauldougan this duplicates this right?

could we close the other one if so?

elenaschwan
elenaschwan approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@elenaschwan elenaschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@elenaschwan elenaschwan mentioned this pull request Jan 26, 2024
Closed
@pauldougan pauldougan merged commit d400162 into main Jan 26, 2024
1 check passed
@pauldougan pauldougan deleted the remove-redundant-paas-manifest branch January 26, 2024 12:34
@pauldougan
Copy link
Contributor Author

@huwd yes need to tidy up the other one which was from a branch in my fork. Will retire thr fork and tidy up the issues etc

@pauldougan
Copy link
Contributor Author

Ok I killed my fork now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwd huwd huwd approved these changes

@elenaschwan elenaschwan elenaschwan approved these changes

@PippaClarkGDS PippaClarkGDS Awaiting requested review from PippaClarkGDS

@sdurnberger sdurnberger Awaiting requested review from sdurnberger

@govuk-one-login-gds-members-bot govuk-one-login-gds-members-bot Awaiting requested review from govuk-one-login-gds-members-bot

Assignees
No one assigned
Labels
housekeeping keeping the house in order
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the manifest.yaml file which is a relic deplying to the defunct GOV.UK PaaS
3 participants
@pauldougan @huwd @elenaschwan