Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat VOT validation guidance in token validation section #245

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

ethanmills
Copy link
Member

@ethanmills ethanmills commented Aug 15, 2024

Why

These validation steps are essential to guard against request tampering

What

Update the token validation guidance and emphasise the importance of it. Adapted from https://github.com/govuk-one-login/tech-docs/blob/main/source/integrate-with-integration-environment/prove-users-identity.html.md.erb#L254

image

Technical writer support

Do you need a tech writer's support, for example to review your PR?
Yes

How to review

Tell reviewers how to assess your changes.

Changelog

If this change is significant (for example, launching a new feature or deprecating a feature), you should update the changelog found at partials/_changelog.erb under the heading 'Documentation updates'.

Confirm

  • I have checked if any docs change here also requires updates to other repositories (ADRs / RFCs, README.md, Team Manual, elsewhere in these docs)
  • Where there is any overlap I have updated or opened a PR for corresponding changes

@ethanmills ethanmills marked this pull request as ready for review August 15, 2024 14:24
@ethanmills ethanmills merged commit 624072a into main Aug 21, 2024
2 checks passed
@ethanmills ethanmills deleted the update-token-validation branch August 21, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants