AP-355 Ensure generaAPted redirect are served as text/html mime type #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure that page redirects configured in config/tech-docs.yml are served with the right mime type rather than as binaries - Update default mime type in nginx.conf - add a helper script preview-with-nginx.sh to build content, dockerize nginx and run locally on port 80
PippaClarkGDS
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-355
Why
Explain why these changes are necessary.
What
We need to ensure that page redirects configured in config/tech-docs.yml are served with the right mime type rather than as binaries and downloaded
Technical writer support
Do you need a tech writer's support, for example to review your PR? YES
How to review
git clone https://github.com/govuk-one-login/tech-docsgit checkout branch./preview-with-nginx.shhttp://localhost/go-liveand sure it redirects correctlyChangelog
This is a bugfix pr to address an issue with redirects so not required
Confirm