Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-1254: Add information relating to max age #304

Merged
merged 11 commits into from
Jan 27, 2025
Merged

Conversation

billrdunn
Copy link
Contributor

@billrdunn billrdunn commented Dec 9, 2024

Why

We will soon be supporting max age for some RPs. They will need to know how to include max age in their authorize request, and how to understand the auth_time claim in the response.

What

Some additional information relating to the above.

Technical writer support

Should max age be included in the example requests? Bearing in mind that max age will not be available to all RPs.

How to review

Check that my words are technically accurate and fit in the with the style of the documentation.

Changelog

If this change is significant (for example, launching a new feature or deprecating a feature), you should update the changelog found at partials/_changelog.erb under the heading 'Documentation updates'.

Confirm

  • I have checked if any docs change here also requires updates to other repositories (ADRs / RFCs, README.md, Team Manual, elsewhere in these docs)
  • Where there is any overlap I have updated or opened a PR for corresponding changes

@CarlyG55
Copy link
Contributor

We probably want to update the changelog for this change

@pauldougan
Copy link
Contributor

We probably want to update the changelog for this change

+1 for adding it to the changelog, I was about to suggest this but you beat me to it!

CarlyG55
CarlyG55 previously approved these changes Jan 13, 2025
Copy link
Contributor

@PippaClarkGDS PippaClarkGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, can take another look when these are resolved

philf999
philf999 previously approved these changes Jan 23, 2025
Copy link
Contributor

@philf999 philf999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but happy to approve

@CarlyG55 CarlyG55 merged commit 3daf077 into main Jan 27, 2025
2 checks passed
@CarlyG55 CarlyG55 deleted the ATO-1254/max-age branch January 27, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants