-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATO-1254: Add information relating to max age #304
Conversation
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
ebf1413
to
4ac614e
Compare
We probably want to update the changelog for this change |
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
+1 for adding it to the changelog, I was about to suggest this but you beat me to it! |
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
…r-user.html.md.erb
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
…r-user.html.md.erb Co-authored-by: Carly Gilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, can take another look when these are resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but happy to approve
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Show resolved
Hide resolved
…r-user.html.md.erb Co-authored-by: PippaClarkGDS <[email protected]>
Why
We will soon be supporting max age for some RPs. They will need to know how to include max age in their authorize request, and how to understand the auth_time claim in the response.
What
Some additional information relating to the above.
Technical writer support
Should max age be included in the example requests? Bearing in mind that max age will not be available to all RPs.
How to review
Check that my words are technically accurate and fit in the with the style of the documentation.
Changelog
If this change is significant (for example, launching a new feature or deprecating a feature), you should update the changelog found at
partials/_changelog.erb
under the heading 'Documentation updates'.Confirm