Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-426 - updates return code information and access denied error messaging #320

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

PippaClarkGDS
Copy link
Contributor

@PippaClarkGDS PippaClarkGDS commented Feb 5, 2025

AP-426

Why

Return code information wasn't consistent and access_denied error messaging was confusing.

What

Updates information on return codes and access_denied error.

Technical writer support

This will need tech writer review.

How to review

n/a

Changelog

Will check if this needs reflecting on the changelog.

Confirm

  • I have checked if any docs change here also requires updates to other repositories (ADRs / RFCs, README.md, Team Manual, elsewhere in these docs)
  • Where there is any overlap I have updated or opened a PR for corresponding changes

@PippaClarkGDS PippaClarkGDS marked this pull request as draft February 5, 2025 14:59
@PippaClarkGDS
Copy link
Contributor Author

Hi @philf999 and @pauldougan - as chatted, here's the PR with the access_denied fixes, as well as some tweaks to returnCode wording. It touches a lot of places in the docs so have a look and lmk what you think. Can put a follow up session in if we need to talk things through.

Copy link
Contributor

@philf999 philf999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few suggestions

@PippaClarkGDS
Copy link
Contributor Author

@philf999 @pauldougan have now incorporated Phil's suggestions. Are you happy to sign this off from a SME POV? I'll then put it to tech writer review.

@pauldougan pauldougan changed the title updates return code information and access denied error messaging PA_426 - updates return code information and access denied error messaging Feb 17, 2025
@pauldougan pauldougan changed the title PA_426 - updates return code information and access denied error messaging AP-426 - updates return code information and access denied error messaging Feb 17, 2025
pauldougan
pauldougan previously approved these changes Feb 17, 2025
Copy link
Contributor

@pauldougan pauldougan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PippaClarkGDS looks good to me, have reviewed that changes in context and everything links up as expected, lets ship it!

@PippaClarkGDS
Copy link
Contributor Author

sending to TW review

claire-cheuk
claire-cheuk previously approved these changes Feb 18, 2025
Copy link
Contributor

@claire-cheuk claire-cheuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny suggestion - this looks really good!

source/partials/_authorize-errors.erb Outdated Show resolved Hide resolved
@PippaClarkGDS PippaClarkGDS marked this pull request as ready for review February 19, 2025 09:38
Copy link
Contributor

@philf999 philf999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@PippaClarkGDS PippaClarkGDS merged commit d444896 into main Feb 19, 2025
3 checks passed
@PippaClarkGDS PippaClarkGDS deleted the access-denied-error branch February 19, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants