-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP-426 - updates return code information and access denied error messaging #320
Conversation
Hi @philf999 and @pauldougan - as chatted, here's the PR with the access_denied fixes, as well as some tweaks to returnCode wording. It touches a lot of places in the docs so have a look and lmk what you think. Can put a follow up session in if we need to talk things through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few suggestions
source/before-integrating/register-and-manage-your-service.html.md.erb
Outdated
Show resolved
Hide resolved
source/integrate-with-integration-environment/authenticate-your-user.html.md.erb
Outdated
Show resolved
Hide resolved
@philf999 @pauldougan have now incorporated Phil's suggestions. Are you happy to sign this off from a SME POV? I'll then put it to tech writer review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PippaClarkGDS looks good to me, have reviewed that changes in context and everything links up as expected, lets ship it!
sending to TW review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny suggestion - this looks really good!
Co-authored-by: Claire Cheuk <[email protected]>
d13dd77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
AP-426
Why
Return code information wasn't consistent and access_denied error messaging was confusing.
What
Updates information on return codes and access_denied error.
Technical writer support
This will need tech writer review.
How to review
n/a
Changelog
Will check if this needs reflecting on the changelog.
Confirm