Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated max_age param guidance to be clearer #327

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ImogenCraigmile
Copy link
Contributor

@ImogenCraigmile ImogenCraigmile commented Feb 10, 2025

Why

Changes requested by a developer via email to make it clearer about how to request the max_age parameter

What

Updated wording to make it clearer

Technical writer support

@PippaClarkGDS has reviewed by another once over would be appreciated before merging

How to review

See changed files

Changelog

it's a small change to the wording so left it out of the changelog, when max_age was added it was included in the changelog

Confirm

  • I have checked if any docs change here also requires updates to other repositories (ADRs / RFCs, README.md, Team Manual, elsewhere in these docs)
  • Where there is any overlap I have updated or opened a PR for corresponding changes

@ImogenCraigmile ImogenCraigmile changed the title Update authenticate-your-user.html.md.erb Updated max_age param guidance to be clearer Feb 10, 2025
Copy link
Contributor

@claire-cheuk claire-cheuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ImogenCraigmile ImogenCraigmile merged commit 9828d7d into main Feb 10, 2025
2 checks passed
@ImogenCraigmile ImogenCraigmile deleted the max_age_parameter_updates branch February 10, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants