Skip to content

Commit

Permalink
Fix upgrade notes and changelog entry
Browse files Browse the repository at this point in the history
Signed-off-by: Callum Brown <[email protected]>
Co-authored-by: Patrick Cloke <[email protected]>
  • Loading branch information
govynnus and clokep committed Aug 15, 2021
1 parent c2995b5 commit 70e653e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion changelog.d/10561.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Handle failure of User-Interactive Authentication when using a fallback. Contributed by Callum Brown.
Display an error on User-Interactive Authentication fallback pages when authentication fails. Contributed by Callum Brown.
10 changes: 4 additions & 6 deletions docs/upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,14 @@ environment variable.
See [using a forward proxy with Synapse documentation](setup/forward_proxy.md) for
details.

## UIA fallback templates can display errors
## User-interactive authentication fallback templates can now display errors

This may affect you if you make use of custom HTML templates for the
[reCAPTCHA](../synapse/res/templates/recaptcha.html) and
[reCAPTCHA](../synapse/res/templates/recaptcha.html) or
[terms](../synapse/res/templates/terms.html) fallback pages.
There is no configuration option for these templates.

The template can now use an optional `error` variable, which is defined if
the authentication process failed. See the default templates linked above for
an example.
The template is now provided an `error` variable if the authentication
process failed. See the default templates linked above for an example.

# Upgrading to v1.39.0

Expand Down

0 comments on commit 70e653e

Please sign in to comment.