-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the output files as a UMD module #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! Does this mean we can directly call the package from https://unpkg.com as well? 😃
@@ -6,3 +6,4 @@ npm-debug.log | |||
_book | |||
lib | |||
_site | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind I'd skip this change, as it's not related to the source code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "react-day-picker", | |||
"version": "2.4.1", | |||
"version": "2.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to cut a minor release (hence 2.5.0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
I've cleaned the history a bit whilst applying the suggested changes. Also, in regards to the https://unpkg.com integration there's additional steps to be made (based from this changes) which are specified in the |
Thanks a lot! I'll work on the unpkg thing before releasing on npm. |
Hey @pguimera, I've published v2.5.0. It works now from unpkg as well 🙌 |
Awesome news @gpbl, thanks for that. I can now use this amazing library in my project without having to do weird tricks in my tooling 😄 |
As the title says, I've updated webpack's output to build the file as a UMD module to improve the library's compatibility when using the built file directly.