Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgsl: Add scalar overloads of any() and all() #2174

Merged
merged 1 commit into from
Oct 19, 2021
Merged

wgsl: Add scalar overloads of any() and all() #2174

merged 1 commit into from
Oct 19, 2021

Conversation

ben-clayton
Copy link
Contributor

Both of these builtins just return the boolean argument, which logically is how a single-element vector would behave.

This reduces friction when writing generic / generated code.

@ben-clayton
wgsl: Add scalar overloads of any() and all()
2a87a08 
Both of these builtins just return the boolean argument, which logically is how a single-element vector would behave.

This reduces friction when writing generic / generated code.
@github-actions
Copy link
Contributor

Previews, as seen when this build job started (2a87a08):
WebGPU | IDL
WGSL
Explainer

kvark
kvark approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with length/distance, which we also made available in scalar form.

@kdashg kdashg merged commit 21de381 into gpuweb:main Oct 19, 2021
@ben-clayton ben-clayton deleted the add-scalar-any-all branch October 19, 2021 18:20
github-actions bot added a commit that referenced this pull request Oct 19, 2021
@ben-clayton @github-actions
wgsl: Add scalar overloads of any() and all() (#2174)
104645c 
SHA: 21de381
Reason: push, by @jdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2021
@ben-clayton @github-actions
wgsl: Add scalar overloads of any() and all() (#2174)
537ac11 
SHA: 21de381
Reason: push, by @jdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2021
@ben-clayton @github-actions
wgsl: Add scalar overloads of any() and all() (#2174)
138016e 
SHA: 21de381
Reason: push, by @jdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kdashg
Copy link
Contributor

kdashg commented Oct 20, 2021

WGSL meeting minutes 2021-10-19
  • Merged.

@teoxoy teoxoy mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-clayton @kdashg @kvark