no more Backend::get_type()

[gquintard]

No description provided.

[gquintard]

@nyurik, the CI is broken because of Varnish packages not installing, which I'll look at, however, running locally, it looks bindgen is creating code that upsets clippy:

$ just ci-test
rustc --version
rustc 1.83.0 (90b35a623 2024-11-26)
cargo --version
cargo 1.83.0 (5ffbef321 2024-10-29)
cargo fmt --all -- --check
cargo clippy --all-targets --workspace $(/home/guillaume/.cargo/bin/just get-package-exclude-args) -- -D warnings
warning: [email protected]: Generated bindings from Varnish 7.6.1 differ from checked-in bindings.for-docs. Update with   cp /home/guillaume/work/varnish-rs/target/debug/build/varnish-sys-74fd726f6665b6b4/out/bindings.rs varnish-sys/bindings.for-docs
    Checking varnish-sys v0.4.0 (/home/guillaume/work/varnish-rs/varnish-sys)
error: calling `CStr::new` with a byte string literal
   --> /home/guillaume/work/varnish-rs/target/debug/build/varnish-sys-74fd726f6665b6b4/out/bindings.rs:711:14
    |
711 |     unsafe { ::std::ffi::CStr::from_bytes_with_nul_unchecked(b"Log\0") };
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Log"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals
    = note: `-D clippy::manual-c-str-literals` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_c_str_literals)]`

[nyurik]

hm, this is weird - i tried just ci-test with both 1.83 and 1.84 and both worked. I also tried it in a docker container - also no issues. Please do just clean and see if you can reproduce in a docker?

[gquintard]

uh, nevermind, that worked

[gquintard]

all good?

[nyurik]

perfect, thanks! :)