-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for org.graalvm.nativeimage.libgraal module #480
Conversation
Partially closes graalvm#479
@zakkak PTAL. Thank you! |
All GHA checks fail with:
Which is caused by the upstream change that is needed even after this. See: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @jerboaa!
I am interested in exploring the option to drop the dependency in Mandrel, but before trying it I wonder if you already did. If yes, what was the main blocker?
I rescheduled a CI run now that oracle/graal#10710 is merged CI now fails with:
due to Temurin EA builds being on 25+9 while labsjdk has moved to 25+10 |
The idea seems to be that this module is lightweight and long-term a dependency for building the compiler as a native image ( We can reconsider if it's becoming a problem. Thoughts? |
Maybe I can add something to the GHA checks to be able to pin to a certain build. |
e6c4280
to
48c610a
Compare
Well, pinning won't help if we need newer builds. Doh! So we'll have to live with the broken CI and merge. OK? |
The purpose would be just to trim down as much as possible, on the other hand it might be time to start considering adding truffle support so probably not worth it. In any case it's irrelevant to this PR so let's merge. |
Partially closes #479
It also needs an upstream part, tracked in oracle/graal#10708, to get latest graal master building again.