Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] 20.1 with upstream #27

Closed
wants to merge 2 commits into from
Closed

[Sync] 20.1 with upstream #27

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jun 6, 2020

Automated changes by create-pull-request GitHub action

@graalvmbot
Copy link
Collaborator

Hello GitHub Action, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address action -(at)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@jerboaa
Copy link
Collaborator

jerboaa commented Jun 8, 2020

@galderz @zakkak I don't think we want to merge this, do we?

@zakkak
Copy link
Collaborator

zakkak commented Jun 8, 2020

Yes we don't want to merge this and we also don't want to keep popping up so I will disable the auto-sync on 20.1 (and we should probably disable it for all future "release" branches.

@zakkak
Copy link
Collaborator

zakkak commented Jun 8, 2020

Another thing to keep in mind is that we should use our emails for any automation to make OCA bot happy.

@galderz
Copy link
Collaborator

galderz commented Jun 9, 2020

So, shall we just close it for now?

@zakkak
Copy link
Collaborator

zakkak commented Jun 9, 2020

No, if we close it it will re-open automatically.
We need to:

  1. disable the auto PRs
  2. re-evaluate our branching scheme (maybe we need to base our branches on graal tags and not on graal branches, e.g. a branch for 20.1.0 and another for 20.1.1. Graal uses branch 20.1 for all 20.1.x tags AFAIU)

@zakkak
Copy link
Collaborator

zakkak commented Jun 9, 2020

Can be closed after merging #35

@galderz
Copy link
Collaborator

galderz commented Jun 10, 2020

e.g. a branch for 20.1.0 and another for 20.1.1.

+1. It seems we need some stable branch for 20.1.0 so that we can backport things as needed, independent of the move forward to 20.1.1.

@galderz
Copy link
Collaborator

galderz commented Jun 10, 2020

Merged #35 so closing this.

@galderz galderz closed this Jun 10, 2020
@jerboaa
Copy link
Collaborator

jerboaa commented Jun 10, 2020

e.g. a branch for 20.1.0 and another for 20.1.1.

+1. It seems we need some stable branch for 20.1.0 so that we can backport things as needed, independent of the move forward to 20.1.1.

I don't think we need a different branch for this to be possible. We can merge 20.1.1 changes at any time we like into a the existing 20.1 mandrel branch. It would be concerning having to maintain per-tag branches. This can be achieved by tagging, IMO. After a merge of 20.1.1 changes into 20.1 tags would become mandrel-20.1.1-DR1 (from mandrel-20.1.0-DR7, say).

@galderz
Copy link
Collaborator

galderz commented Jun 11, 2020

@jerboaa Hmmm, that might simplify things actually. It would be easier to chug along with what happens with the micros than the maintenance involved. This would be something to take into account in the discussion in #40. @jerboaa maybe you can reply there too?

@zakkak zakkak deleted the auto-sync-20.1 branch June 16, 2020 12:30
github-actions bot pushed a commit that referenced this pull request Jun 12, 2021
* Merge JfrSerializer interface into JfrRepository

* Add comment about repository ordering

* Move symbolRepo after methodRepo and stackTraceRepo
zakkak added a commit that referenced this pull request Jan 23, 2025
Add new issue templates for backport requests and community issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants