[23.0] Add JFR threshold checking before event emission #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
roberttoyonaga
added
backport
affects/23.0
and removed
OCA Verified
zakkak
requested changes
Sep 19, 2023
There was a problem hiding this comment.
@roberttoyonaga please use git cherry-pick -x for the backports, so that we can map each commit to the one it is being backported from.
I also see some changes not being backported, e.g. oracle@d4a8436#diff-2b7c6208cd16f550c9422b6a4a25cabbb98034543abee1262f531edc253faa02
roberttoyonaga
force-pushed
the
jfr-backport-threshold-23.0
branch
from
212e840 to
a4b52d1
Compare
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@roberttoyonaga now that #577 is merged could you please change the build type in the mandrel.yml workflow to You can do so by adding the following line below |
zakkak
approved these changes
Sep 20, 2023
|
CI failures will be fixed with quarkusio/quarkus#36058, not related with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR backports threshold checking from 23.1 to 23.0. Specified duration thresholds will be checked before emitting events wherever thresholds are supported.
Original PR: oracle#6964
Oracle internal PR: oracle#7066