-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move all of the chatbot component in to js/chatbot #4900
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4900-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/431140b903970d5ab4afa1212da832109f1bfb97/gradio-3.36.1-py3-none-any.whl |
🎉 Chromatic build completed! There are 0 visual changes to review. |
Thanks @pngwn! Just a couple of questions:
type: {
payload: "Array<[string, string]>"
},
description: {
payload: "list of message pairs of"
},
example_data: config.value?.length
? config.value
: [
["Hi", "Hello"],
["1 + 1", "2"]
]
}); So the file doesn't seem to have much purpose. Thinking ahead to community components, it would be really nice if all of the files related to a component were entirely in a single directory (e.g.:
But we have the files for the |
I didn't realise that, in that case we can remove all of these snippets and I'll make sure to do that when I make a big PR for everything else (hopefully tomorrow/fri). Regarding the removal of the file, that is the ultimate goal yes but that will be 'stage 2' listed here. Eventually we will just load directly from This PR specifically was mainly to just get the movage out of the way so that I don't end up with conflicts as @dawoodkhan82 starts to work on the chatbot. There will probably be one or two minor changes but they shouldn't touch the core chatbot code which is the main issue.
So I'm a bit confused about chatbot really, is it static or interactive? It feels like an interactive component but i guess all it actually does is renders content we pass to it? I guess it is less meaningful when there is only one version of a component (unlike say |
I believe that's the case, @aliabd can you confirm that these snippets are no longer used? Everything else looks good to me @pngwn! |
yes we don't use the index.ts files for the API docs anymore. Instead we get the python type/example info from the /info route and the js info from the client .view_api |
Description
This is the file move for the chatbot component, to get out of @dawoodkhan82's way. Apologies for the delay!
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh
Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md
:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.md
file and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".