Minor bug fix sweep #5284

aliabid94 · 2023-08-21T20:48:41Z

Was going through a bunch of demos and cleaning up any minor issues I found.

LIBRARY CHANGES:

Our use of __exit__ was catching errors and corrupting the traceback of any component that failed to instantiate (try running blocks_kitchen_sink off main for an example). Now the __exit__ exits immediately if there's been an exception, so the original exception can be printed cleanly
HighlightedText was rendering weird, cleaned it up

DOCS CLEANUP:

Removed documentation of gr.Box, a deprecated and broken layout object.
People keep trying to set kwarg scale to values between 0-1, which causes issues as CSS flex-grow behaves differently with non integer values. We also had some examples in our demo where we used non integer values. Raise a warning now if scale is set to these values.
Blocks.load had lost its function metadata due to the class_or_instancemethod decorator, so there was no hinting. Fixed.

DEMO CLEANUP:

Removed usage of deprecated methods and arguments, e.g. .style(), gr.Box() border=..., rounded=...
Fixed broken blocks_kitchen_sink demo, which was broken because 1) tried loading an image link that was broken and 2) tried setting an example for CheckboxGroup that was not an original choice.

gradio-pr-bot · 2023-08-21T20:48:58Z

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
	Visual tests	all good!	Build review
🦄	Changes	detected!	Details
📓	Notebooks	matching!

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a86ebbb091d666280b5e12b98c6272fe3f624811/gradio-3.41.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a86ebbb091d666280b5e12b98c6272fe3f624811#subdirectory=client/python"

gradio-pr-bot · 2023-08-21T20:49:30Z

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
`@gradio/highlightedtext`	`patch`
`gradio`	`patch`
`website`	`patch`

With the following changelog entry.

Minor bug fix sweep

Our use of exit was catching errors and corrupting the traceback of any component that failed to instantiate (try running blocks_kitchen_sink off main for an example). Now the exit exits immediately if there's been an exception, so the original exception can be printed cleanly

HighlightedText was rendering weird, cleaned it up

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

Something isn't right?

Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

…o_cleanup

demo/blocks_joined/run.py

demo/blocks_style/run.py

demo/fake_gan_no_input/run.py

aliabd · 2023-08-22T22:48:48Z

looks like backend typecheck is failing because __exit__ now requires exc_type and you didn't pass that in launch here

…nto demo_cleanup

This reverts commit 189b4e8.

freddyaboulton

Looks good @aliabid94 ! Box is still showing up for me in the PR deploy but other than that this looks good. Might be good to remove style from the following demo files too.

demo/clustering/run.py
demo/clustering/run.ipynb
demo/native_plots/scatter_plot_demo.py
demo/native_plots/line_plot_demo.py
demo/native_plots/bar_plot_demo.py

gradio/layouts.py

abidlabs · 2023-08-25T16:35:57Z

HighlightedText was rendering weird, cleaned it up

rendering weird how?

gradio/blocks.py

gradio/components/gallery.py

abidlabs · 2023-08-25T16:54:50Z

LGTM @aliabid94! Thanks for making these fixes, they were long overdue

Can you update the changelog to include both of the library changes? You can now use bullet lists in the changelog as described by @pngwn here: #5261

aliabid94 · 2023-08-25T18:24:08Z

Looks good @aliabid94 ! Box is still showing up for me in the PR deploy but other than that this looks good. Might be good to remove style from the following demo files too.

Fixed

rendering weird how?

* changes * changes * add changeset * changes * changes * fix box changes on website * add changeset * changes * changes * Revert "changes" This reverts commit 189b4e8. * chanegs * changes * changes * changes * changes * add changeset * Update fancy-bats-deny.md --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: aliabd <[email protected]> Co-authored-by: Abubakar Abid <[email protected]>

* disable sanitize * add changeset * Fix devcontainer postCreateCommand (#5289) * add chmod commands to grant execute permissions to each script before running them * increase the memory limit * Increase memory requirement to 8 * Setting a minimum specification for codespace machines * Rotate axes labels on LinePlot, BarPlot, and ScatterPlot (#5305) * add chmod commands to grant execute permissions to each script before running them * increase the memory limit * Increase memory requirement to 8 * Setting a minimum specification for codespace machines * Added label_angle parameter to LinePlot * add the x_label_angle and y_label_angle to the postprocess * Add x_label_angle and y_label_angle to ScatterPlot * Add x_label_angle and y_label_angle to BarPlot * Remove postCreateCommand update from this PR, it is in its own PR * Remove custumization on the devcontainer, it is on another PR * Remove extra line on the devcontainer, it is on another PR * add changeset * update the parameter definition in the docstring --------- Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> * `make_waveform()` twitter video resolution fix (#5296) * waveform res fix * add changeset * add changeset * Improve audio streaming (#5238) * changes * changes * add changeset * add changeset * chages * Update silver-clowns-brush.md * changes * chagers * changes * Update silver-clowns-brush.md * change * change --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: pngwn <[email protected]> * Tweaks to `icon` parameter in `gr.Button()` (#5285) * button * add changeset * fix * add changeset * add changeset * types * type fix * formatting * fix based on review * fix unit tests * stories --------- Co-authored-by: gradio-pr-bot <[email protected]> * test * test --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: aliabid94 <[email protected]> Co-authored-by: pngwn <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> * Allow caching examples with streamed output (#5295) * changes * changes * add changeset * add changeset * chages * Update silver-clowns-brush.md * changes * chagers * changes * Update silver-clowns-brush.md * change * change * change * changes * chages * changes * add changeset * changes * changes * changes --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: pngwn <[email protected]> * Create event listener table for components on docs (#5298) * changes * changes * remove languages from code docs * fix img path in guide * rework event listeners * add changeset * remove console log * name it event arguments * Update js/_website/src/lib/components/EventListeners.svelte Co-authored-by: Abubakar Abid <[email protected]> * Update js/_website/src/lib/components/EventListeners.svelte Co-authored-by: Abubakar Abid <[email protected]> * requested changes --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> * merge * fix (#5308) * only start listening for events after the components are mounted (#5312) * only start listening for events after the components are mounted * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * Restores missing part of bottom border on file component (#5313) * removes missing part of bottom border on file component * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * chore: update versions (#5177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Test Blocks.svelte footer copy (#5307) * test test * fix test * tweak * tweak test name * ensure login form has correct styles (#5324) * fix changelog generation (#5328) * Add ignore scripts to pnpm i in pypi action (#5316) * add json generation to prepare * add changeset * remove pnpm prepare * add changeset * bring back prepare, add ignore scripts * delete changeset * add to right commadn * add frozen lockfile to gh_action_pypi * remove unused gh_action_pypi script * remove unused scripts --------- Co-authored-by: gradio-pr-bot <[email protected]> * ensure dropdown stays open when identical data is passed in (#5323) * ensure dropwdown stays open when new data is passed in * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * Fix ci again again again (#5329) * fix changelog generation * fix changelog generation * fix * chore: update versions (#5326) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix ci again again again (#5330) * fix changelog generation * fix changelog generation * fix * fix script * Fix ci again again again (#5331) * fix changelog generation * fix changelog generation * fix * fix script * fix script * Fix ci again again again (#5332) * fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars * Fix ci again again again (#5333) * fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars * fix vars * Fix Checkbox select dispatch (#5340) * Fix bug * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * Minor bug fix sweep (#5284) * changes * changes * add changeset * changes * changes * fix box changes on website * add changeset * changes * changes * Revert "changes" This reverts commit 189b4e8. * chanegs * changes * changes * changes * changes * add changeset * Update fancy-bats-deny.md --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: aliabd <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> * Fix: wrap avatar-image in a div to clip its shape (#5319) * fix: wrap avatar-image in a div to clip its shape and add data url support * add changeset * revert get file from data url * add changeset --------- Co-authored-by: Dawood Khan <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> * chore: update versions (#5341) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * add kwarg to markdown * add changeset * config --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Faiga Alawad <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: aliabid94 <[email protected]> Co-authored-by: pngwn <[email protected]> Co-authored-by: Ali Abdalla <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Hannah <[email protected]> Co-authored-by: Freddy Boulton <[email protected]> Co-authored-by: Keldos <[email protected]>

aliabid94 added 2 commits August 21, 2023 13:39

changes

c3803b3

changes

12765d7

add changeset

dabfe62

aliabid94 requested review from aliabd and abidlabs August 21, 2023 20:49

aliabid94 and others added 6 commits August 21, 2023 14:03

changes

a735072

changes

e908031

changes

83802d7

fix box changes on website

ac3309a

Merge branch 'demot_cleanup' of github.com:gradio-app/gradio into dem…

dbc9e8a

…o_cleanup

add changeset

f10e020

aliabd reviewed Aug 22, 2023

View reviewed changes

demo/blocks_joined/run.py Outdated Show resolved Hide resolved

demo/blocks_style/run.py Outdated Show resolved Hide resolved

demo/blocks_style/run.py Outdated Show resolved Hide resolved

demo/fake_gan_no_input/run.py Outdated Show resolved Hide resolved

aliabid94 added 9 commits August 23, 2023 11:26

changes

0660433

Merge branch 'main' into demo_cleanup

1b126ae

Merge remote-tracking branch 'origin' into demo_cleanup

7314f6b

Merge branch 'demo_cleanup' of https://github.com/gradio-app/gradio i…

55d5a04

…nto demo_cleanup

changes

189b4e8

Revert "changes"

35c0987

This reverts commit 189b4e8.

chanegs

e6ce2d9

Merge remote-tracking branch 'origin' into demo_cleanup

0bf4685

changes

adcfd6d

freddyaboulton approved these changes Aug 24, 2023

View reviewed changes

gradio/layouts.py Show resolved Hide resolved

aliabid94 added 4 commits August 24, 2023 14:32

changes

c260851

changes

a8051b6

changes

6cc2f75

Merge remote-tracking branch 'origin' into demo_cleanup

6d8b1b5

abidlabs added the v: patch A change that requires a patch release label Aug 25, 2023

gradio-pr-bot and others added 2 commits August 25, 2023 16:36

add changeset

e32568e

Merge branch 'main' into demo_cleanup

861e95b

abidlabs reviewed Aug 25, 2023

View reviewed changes

gradio/blocks.py Show resolved Hide resolved

abidlabs reviewed Aug 25, 2023

View reviewed changes

gradio/components/gallery.py Show resolved Hide resolved

abidlabs approved these changes Aug 25, 2023

View reviewed changes

Update fancy-bats-deny.md

02f97bf

aliabid94 merged commit 5f25eb6 into main Aug 25, 2023

aliabid94 deleted the demo_cleanup branch August 25, 2023 18:31

pngwn mentioned this pull request Aug 25, 2023

chore: update versions #5341

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor bug fix sweep #5284

Minor bug fix sweep #5284

aliabid94 commented Aug 21, 2023 •

edited

Loading

gradio-pr-bot commented Aug 21, 2023 •

edited

Loading

gradio-pr-bot commented Aug 21, 2023 •

edited

Loading

Something isn't right?

aliabd commented Aug 22, 2023

freddyaboulton left a comment

abidlabs commented Aug 25, 2023

abidlabs commented Aug 25, 2023 •

edited

Loading

aliabid94 commented Aug 25, 2023

Minor bug fix sweep #5284

Minor bug fix sweep #5284

Conversation

aliabid94 commented Aug 21, 2023 • edited Loading

gradio-pr-bot commented Aug 21, 2023 • edited Loading

🪼 branch checks and previews

gradio-pr-bot commented Aug 21, 2023 • edited Loading

🦄 change detected

This Pull Request includes changes to the following packages.

With the following changelog entry.

Something isn't right?

aliabd commented Aug 22, 2023

freddyaboulton left a comment

Choose a reason for hiding this comment

abidlabs commented Aug 25, 2023

abidlabs commented Aug 25, 2023 • edited Loading

aliabid94 commented Aug 25, 2023

aliabid94 commented Aug 21, 2023 •

edited

Loading

gradio-pr-bot commented Aug 21, 2023 •

edited

Loading

gradio-pr-bot commented Aug 21, 2023 •

edited

Loading

abidlabs commented Aug 25, 2023 •

edited

Loading