Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in Typescript #8

Closed
wants to merge 8 commits into from
Closed

Rewrite in Typescript #8

wants to merge 8 commits into from

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Oct 18, 2023 •
edited
Loading

Changes

  • Reimplement using Typescript
  • Combine TOS acceptance and publication in a single workflow
  • Remove dependencies to third party packages (contributor-assistant, dawidd6/action-download-artifact)
  • Only PR submitter needs to accept the TOS
  • Do not fail the workflow if no artifacts were found or the TOS weren't accepted
  • Delete workflow artifacts upon successful publication

Pending Changes

  • Share packages across projects (layout.ts, io.ts)

@jprinet jprinet requested a review from bigdaz October 18, 2023 21:16
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch 2 times, most recently from e1acf0d to 054d01b Compare October 19, 2023 05:42
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch from 054d01b to b20715b Compare October 19, 2023 07:33
@jprinet jprinet marked this pull request as ready for review October 31, 2023 14:52
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch 3 times, most recently from ff9946e to e81c261 Compare October 31, 2023 15:13
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch 2 times, most recently from dcbfb78 to 9a40bc6 Compare October 31, 2023 15:27
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch from 9a40bc6 to a417cc2 Compare October 31, 2023 15:34
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch 6 times, most recently from d57b9e8 to 03621d4 Compare November 2, 2023 15:58
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch from 03621d4 to f9cdc80 Compare November 2, 2023 16:06
@jprinet jprinet force-pushed the jprinet/typescript-implementation branch from daae685 to a86ae2a Compare November 2, 2023 17:32
@jprinet
Copy link
Member Author

jprinet commented Nov 23, 2023

Closing as the legal requirements have changed and imply an implementation change

@jprinet jprinet closed this Nov 23, 2023
@jprinet jprinet deleted the jprinet/typescript-implementation branch January 30, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigdaz bigdaz Awaiting requested review from bigdaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jprinet