Add support for dynamic tests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean Gauthier <[email protected]>
Signed-off-by: Jean Gauthier <[email protected]>
jean-andre-gauthier
force-pushed
the
jgauthier/364/add-support-dynamic-tests
branch
from
1ca5b4e to
daef9b4
Compare
Signed-off-by: Jean Gauthier <[email protected]>
pshevche
approved these changes
Jan 17, 2025
plugin/src/test/groovy/org/gradle/testretry/testframework/JUnit5FuncTest.groovy
Outdated
Show resolved
Hide resolved
| @@ -35,7 +35,7 @@ | |||
| abstract class BaseJunitTestFrameworkStrategy implements TestFrameworkStrategy { | |||
|
|
|||
| public static final Logger LOGGER = LoggerFactory.getLogger(JunitTestFrameworkStrategy.class); | |||
| private static final Pattern PARAMETERIZED_SUFFIX_PATTERN = Pattern.compile("(?:\\([^)]*?\\))?(?:\\[[^]]*?])?$"); | |||
| private static final Pattern PARAMETERIZED_SUFFIX_PATTERN = Pattern.compile("(?:\\([^)]*?\\))?(?:\\[[^]]*?])*$"); | |||
There was a problem hiding this comment.
💭 Sometimes I have a feeling that the entire plugin relies on this one regex :D
Signed-off-by: Jean Gauthier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
PARAMETERIZED_SUFFIX_PATTERNinBaseJunitTestFrameworkStrategyto support dynamic tests, by allowing an arbitrary number of trailing[...]